Handle cases where site creation fails in New-PnPSite #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle cases where site creation fails in New-PnPSite by throwing a clearer exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Improves #4082
What is in this Pull Request ?
Handle cases where site creation fails in New-PnPSite by throwing a clearer exception.
The previous code would try to dereference
returnedContexteven when null, throwing aObject reference not set to an instance of an object.exception. This happens becauseFramework.Sites.SiteCollection.Create()returns null in some cases, like if the site url was not retrieved after enough tries.I'm not sure if the message should be changed. At this point of the callstack we have no idea what went wrong during the creation and if the site was fully created and configured or not. It might be that there was an issue only when retrieving the SPO ClientContext but everything else worked fine.
In any case, anything should be better than an unhandled null exception 😃