Fix floating point issue #6467
Open
Fix floating point issue #6467
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes blocks not placing right next to the player at certain positions
|
I'm not seeing the issue, please mention reproduction steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Fixes blocks not placing right next to the player at certain positions
Relevant issues
Currently you cannot place blocks right next to yourself at some positions due to floating point issues
Changes
API changes
No significant API changes
Behavioural changes
Might affect some extremely precise checks
Backwards compatibility
No Backwards compatibility issues
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)