6161 implement interface common block properties #6383
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dktapps Just want to get a quick review of this to make sure its headed in the intended direction |
|
Would this be better utilized trait, I think the is the direction most items like this follow. |
Probably should use the trait as there is Horizontal and AnyFacing traits that could be used Possibly out of scope? Would likely fit more into another PR for cleaning up the code |
| /** | ||
| * Set the current facing direction of the block | ||
| */ | ||
| public function setFacing(int $facing) : object; |
| @@ -40,7 +41,7 @@ | |||
| use pocketmine\world\World; | |||
| use function ceil; | |||
|
|
|||
| class Painting extends Entity{ | |||
| class Painting extends Entity implements FacingInterface{ | |||
There was a problem hiding this comment.
Design error, you're using an interface made for blocks in an entity, I don't think you should do that
ShockedPlot7560
added
Category: API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
The goal of this is to give plugins an easier way of accessing common properties of blocks such as facing and on/off
Relevant issues
Fixes #6161