Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: remove unused dynamic PHP scripts #380

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Aug 27, 2024

On security request.

Note: Some of them are still referenced here and there.
But since PHP doesn't work anyway we can have them removed.
It doesn't change the outcome.

Preview: https://janekmi.github.io/


This change is Reviewable

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi changed the title theme: remove unused dynamic PHP script theme: remove unused dynamic PHP scripts Aug 28, 2024
@janekmi janekmi requested a review from grom72 August 28, 2024 14:49
On security request.

Note: Some of them are still referenced here and there.
But since PHP doesn't work anyway we can have them removed.
It doesn't change the outcome.

Signed-off-by: Jan Michalski <[email protected]>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 25 of 25 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit c7811e8 into pmem:main Aug 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants