Enable libtraceevent/libtracefs support for Fedora #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just posted this on the mailing list. Please take a look and confirm that's what you want. https://lore.kernel.org/nvdimm/[email protected]/ |
AlisonSchofield
pushed a commit
that referenced
this pull request
Aug 22, 2024
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2, the expression "0%{?rhel}" evaluates to zero on Fedora, so the conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less than 9. The result is that ndctl builds for Fedora lack support for libtraceevent and libtracefs. Correct the expression. Reposted here from github pull request: #266 Signed-off-by: Jerry James <[email protected]> Reviewed-by: Vishal Verma <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Signed-off-by: Alison Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2, the expression
0%{?rhel}evaluates to zero on Fedora, so the conditional%if 0%{?rhel} < 9evaluates to true, since 0 is less than 9. The result is that ndctl builds for Fedora lack support for libtraceevent and libtracefs, which is fixed by this PR.