Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndctl/lib/libndctl.c, add read dirty_shutdown info in function popula… #264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smellywave
Copy link

ndctl/lib/libndctl.c: add read dirty_shutdown info in populate_cxl_dimm_attributes()

First, dirty_shutdown info is an essential info and must not be defaut value when calling PMDK create-namespace command; Sencond, it is necessary to read basic dimm info from sysfs in regardless of keep it with defaut value, which is always negative and result in error in application

Note that PMDK use at link: https://github.com/pmem/pmdk/blob/master/src/libpmem2/usc_ndctl.c : int pmem2_source_device_usc()->ndctl_dimm_get_dirty_shutdown()

…te_cxl_dimm_attributes()

First, dirty_shutdown info is an essential info and must not be defaut value when calling PMDK create-namespace command;
Sencond, it is necessary to read basic dimm info from sysfs in regardless of keep it with defaut value, which is always negative and result in error in application

Note that PMDK use at link: https://github.com/pmem/pmdk/blob/master/src/libpmem2/usc_ndctl.c : int pmem2_source_device_usc()->ndctl_dimm_get_dirty_shutdown()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant