don't try to reconfig a inactive/destroyed namespace #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I'm wondering if we shouldn't go the other way and /alllow/ reconfiguring an inactive namespace. Seems like a reasonable thing one might expect to do. @djbw Thoughts? |
|
@stellarhopper agree. A reconfig on a namespace with p.size == 0 should reconfigure to a maximally sized namespace with create-namespace defaults. This would seem to need some other pending fixups: In particular: |
|
Those pending fixups have been applied. Is there any remaining issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In namespace_reconfig, quit early if input namespace is of size 0
(inactive/destroyed), specifically setup_namespace should not be called.