Patch 2 #8
Closed
Patch 2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorengordon
requested changes
Aug 8, 2023
Comment on lines
+46
to
+47
| description = "Resource Discovery Description" | ||
| operating_regions = [ |
There was a problem hiding this comment.
Both description and operation_regions need to be variables
Comment on lines
+31
to
+32
| cidr_filter_pattern = "10.*" # Optional, can be customized | ||
| address_family = "IPv4" # Optional, can be customized |
There was a problem hiding this comment.
Both cidr_filter_pattern and address_family need to be varibles
| mycidrs = [for cidr in data.aws_vpc_ipam_pool_cidrs.this.ipam_pool_cidrs : cidr.cidr if cidr.state == "provisioned"] | ||
| } | ||
|
|
||
| resource "aws_ec2_managed_prefix_list" "this" { |
There was a problem hiding this comment.
What is the concept for this resource? Not sure I understand the use case being filled here, in the context of IPAM.
| description = "List of operating regions for IPAM resource discovery." | ||
| type = list(object({ | ||
| region_name = string | ||
| # Include other attributes if needed |
There was a problem hiding this comment.
These comments end up in the README generated by terraform-docs. Remove unnecessary comments from this block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.