refactor stage 1 #13
Closed
refactor stage 1 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorengordon
reviewed
Oct 23, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
lorengordon
reviewed
Oct 27, 2023
johnricords
commented
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
lorengordon
reviewed
Nov 2, 2023
main.tf
Outdated
| resource "aws_vpc_ipam_scope" "this" { | ||
| for_each = { for scope in var.vpc_ipam.scopes : scope.name => scope } | ||
|
|
||
| ipam_id = each.value.ipam_id |
There was a problem hiding this comment.
I think it makes sense for the scopes to always be this ipam. And we can use a precondition to error if the user sets var.vpc_ipam.scopes but does not set var.vpc_ipam.ipam.
Suggested change
| ipam_id = each.value.ipam_id | |
| ipam_id = aws_vpc_ipam.this[0].ipam_id |
lorengordon
reviewed
Nov 8, 2023
lorengordon
reviewed
Nov 8, 2023
johnricords
commented
Nov 9, 2023
johnricords
commented
Nov 9, 2023
johnricords
commented
Nov 9, 2023
lorengordon
reviewed
Nov 9, 2023
lorengordon
reviewed
Nov 9, 2023
lorengordon
reviewed
Nov 9, 2023
johnricords
force-pushed
the
refactor
branch
from
45f04e6
to
a7017ea
Compare
johnricords
commented
Nov 14, 2023
lorengordon
reviewed
Nov 14, 2023
lorengordon
reviewed
Nov 14, 2023
lorengordon
reviewed
Nov 14, 2023
johnricords
force-pushed
the
refactor
branch
from
c48765c
to
377fd50
Compare
lorengordon
reviewed
Nov 15, 2023
lorengordon
reviewed
Nov 15, 2023
lorengordon
reviewed
Nov 15, 2023
lorengordon
reviewed
Nov 15, 2023
lorengordon
reviewed
Nov 15, 2023
lorengordon
reviewed
Nov 15, 2023
johnricords
force-pushed
the
refactor
branch
from
233ad36
to
a473313
Compare
johnricords
force-pushed
the
refactor
branch
from
a473313
to
aeac04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.