Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial release #1

Merged
merged 1 commit into from
Mar 5, 2024
Merged

initial release #1

merged 1 commit into from
Mar 5, 2024

Conversation

johnricords
Copy link
Contributor

@johnricords johnricords commented Feb 16, 2024

Terraform will perform the following actions:

  # module.ec2_account.aws_ebs_encryption_by_default.this will be created
  + resource "aws_ebs_encryption_by_default" "this" {
      + enabled = true
      + id      = (known after apply)
    }

  # module.ec2_account.aws_ec2_image_block_public_access.this will be created
  + resource "aws_ec2_image_block_public_access" "this" {
      + id    = (known after apply)
      + state = "block-new-sharing"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

tests/main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
ec2_account = {
ebs_encryption_by_default = {
enabled = true
default_kms_key = "arn:aws:kms:us-east-1:123456789012:key/abcd-1234"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work even in the test, since the key must exist in order for the resource to be created. Let's just set this to null and leave it to a future action to create a custom key.

Suggested change
default_kms_key = "arn:aws:kms:us-east-1:123456789012:key/abcd-1234"
default_kms_key = null

@johnricords johnricords merged commit 66f400f into plus3it:main Mar 5, 2024
4 of 5 checks passed
@johnricords johnricords deleted the init branch March 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants