generated from plus3it/repo-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial release #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnricords
commented
Feb 16, 2024
•
edited
Loading
edited
johnricords
force-pushed
the
init
branch
2 times, most recently
from
February 16, 2024 04:22
84075e5
to
c46948c
Compare
lorengordon
reviewed
Feb 20, 2024
lorengordon
reviewed
Feb 20, 2024
lorengordon
reviewed
Feb 20, 2024
lorengordon
reviewed
Feb 20, 2024
lorengordon
reviewed
Feb 23, 2024
tests/all-inputs/main.tf
Outdated
ec2_account = { | ||
ebs_encryption_by_default = { | ||
enabled = true | ||
default_kms_key = "arn:aws:kms:us-east-1:123456789012:key/abcd-1234" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work even in the test, since the key must exist in order for the resource to be created. Let's just set this to null
and leave it to a future action to create a custom key.
Suggested change
default_kms_key = "arn:aws:kms:us-east-1:123456789012:key/abcd-1234" | |
default_kms_key = null |
lorengordon
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.