Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lodash to nivo/line's package.json #2608

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonaengs
Copy link

@jonaengs jonaengs commented Jun 13, 2024

import uniqueId from 'lodash/uniqueId'

nivo/line imports uniqueId from lodash in the hooks.js file. However, lodash is not declared as a dependency in nivo/line's package.json file. This was causing my project to crash when using the package with pnpm.

The PR fixes the issue by adding lodash as a dependency

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ❌ Failed (Inspect) Jun 21, 2024 2:36pm

@plouc
Copy link
Owner

plouc commented Jun 20, 2024

@jonaengs, the lock file needs to be updated accordingly, most jobs are failing due to this.

@jonaengs
Copy link
Author

Hey @plouc thanks for the tip. I'm not super experienced with javascript development, so all input is appreciated:) I think I've updated the lockfile correctly, but I see that the workflows are still failing, so maybe I missed something? I've allowed edits by maintainers for the PR, so if you spot my mistake and want to quickly fix it yourself, feel free. Otherwise I'll do my best to fix the issues myself. Though I might need some more pointers before I'm able to make meaningful progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants