Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming to its own package #2337

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Move theming to its own package #2337

wants to merge 42 commits into from

Conversation

plouc
Copy link
Owner

@plouc plouc commented May 11, 2023

@nivo/core contains a bit of everything, and it can lead to circular dependencies (it's the case with @nivo/tooltip for example), so I decided to move it to its own package.

The added benefit is that now this part will be in TypeScript, as @nivo/core is unfortunately still not.

Extra features:

  • We can now define a text outline for most text elements via outlineWidth, outlineColor and outlineOpacity via the theme object.

This introduces some breaking changes:

  • When implementing custom layers/components, you might use useTheme, previously imported from @nivo/core, now it's defined in @nivo/theming
  • The TypeScript definition of a theme changed a little bit, please see the new type in the @nivo/theming package.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ❌ Failed (Inspect) May 14, 2023 1:38am

…CI as it's already done when creating the preview on vercel
@pcorpet
Copy link
Contributor

pcorpet commented Aug 11, 2023

@plouc Any update on this one? It would be useful to get the d3-color vulnerability fix released.

@junaidNadeem
Copy link

junaidNadeem commented Oct 25, 2023

@plouc d3-color vulnerability has posed security challenges for nivo's usage.

Recent upgrade of nivo hasn't resolved it because the version upgrade has brought ESM & CJS modules conflict. Any information about the release date would be greatly appreciated.

Copy link

stale bot commented Mar 13, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants