Merge pull request #214 from plivo/VT-5438

added_new_param_in_getCallDetails_api
plivo · Jun 1, 2023 · 9def7bb · 9def7bb
2 parents 7cf4e76 + 9efade6
commit 9def7bb
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## [4.44.0](https://github.com/plivo/plivo-ruby/tree/v4.38.2) (2023-03-16)
+**Feature : Added new param in getCallDetail api**
+- From now on we can see CNAM(Caller_id name) details at CDR level.
+
 ## [4.43.0](https://github.com/plivo/plivo-ruby/tree/v4.43.0) (2023-05-29)
 **Feature - Recording API changes**
 - Added `monthly_recording_storage_amount`, `recording_storage_rate`, `rounded_recording_duration`, and `recording_storage_duration` parameters to the response for [get single recording API](https://www.plivo.com/docs/voice/api/recording#retrieve-a-recording) and [get all recordings API](https://www.plivo.com/docs/voice/api/recording#list-all-recordings)

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'plivo', '>= 4.43.0'
+gem 'plivo', '>= 4.44.0'
 ```
 
 And then execute:

diff --git a/lib/plivo/resources/calls.rb b/lib/plivo/resources/calls.rb
@@ -233,7 +233,8 @@ def to_s
           caller_name: @caller_name,
           stir_verification: @stir_verification,
           stir_attestation: @stir_attestation,
-          source_ip: @source_ip
+          source_ip: @source_ip,
+          cnam_lookup: @cnam_lookup
         }
         call_details = call_details.select {|k, v| !v.nil? }
         call_details.to_s

diff --git a/lib/plivo/version.rb b/lib/plivo/version.rb
@@ -1,3 +1,3 @@
 module Plivo
-  VERSION = "4.43.0".freeze
+  VERSION = "4.44.0".freeze
 end
diff --git a/spec/mocks/callGetResponse.json b/spec/mocks/callGetResponse.json
@@ -16,5 +16,6 @@
   "total_rate": "0.03570",
   "stir_verification": "Verified",
   "stir_attestation": "A",
-  "source_ip": ""
+  "source_ip": "",
+  "cnam_lookup": "disabled"
 }
diff --git a/spec/mocks/callListResponse.json b/spec/mocks/callListResponse.json
@@ -26,7 +26,8 @@
       "total_rate": "0.00850",
       "stir_verification": "Not Verified",
       "stir_attestation": "",
-      "source_ip": ""
+      "source_ip": "",
+      "cnam_lookup": "disabled"
     },
     {
       "answer_time": "2015-07-26 16:45:02+05:30",
@@ -46,7 +47,8 @@
       "total_rate": "0.00850",
       "stir_verification": "Not Applicable",
       "stir_attestation": "",
-      "source_ip": ""
+      "source_ip": "",
+      "cnam_lookup": "disabled"
     }
   ]
 }
diff --git a/spec/resource_calls_spec.rb b/spec/resource_calls_spec.rb
@@ -20,7 +20,8 @@ def to_json(call)
       total_rate: call.total_rate,
       stir_verification: call.stir_verification,
       stir_attestation:call.stir_attestation,
-      source_ip:call.source_ip
+      source_ip:call.source_ip,
+      cnam_lookup:call.cnam_lookup
     }.to_json
   end