Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT-6901: JWT Token Creation Issues #323

Merged
merged 2 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [v4.60.1](https://github.com/plivo/plivo-node/tree/v4.60.1) (2023-11-28)
**Bug Fix - JWT Token Creation Issues**
- Fix for incorrect token getting created when generated using TypeScript

## [v4.60.0](https://github.com/plivo/plivo-node/tree/v4.60.0) (2023-11-08)
**[BETA] Feature - TollFree Verification API Support**
- API support for Create, Update, Get, Delete and List Tollfree Verification.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.60.0",
"version": "4.60.1",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [
Expand Down
2 changes: 1 addition & 1 deletion types/resources/token.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class CreateTokenResponse {
* @promise {object} returns Call Object
* @fail {Error} returns Error
*/
create( iss: string, sub: string, nbf: number, exp: number, incoming_allow: boolean, outgoing_allow: boolean, app: string, params ? : {}): Promise < CreateTokenResponse > ;
create( iss: string, params ? : {}): Promise < CreateTokenResponse > ;
/**
* Create a token
* @method
Expand Down
6 changes: 3 additions & 3 deletions types/resources/verifyCallerId.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class VerifyCallerIdResponse {
country:string;
createdAt:string;
phoneNumber:string;
subaccount:internal;
subaccount:string;
verificationUuid:string;
}

Expand All @@ -24,7 +24,7 @@ export class GetVerifiedCallerIdResponse {
createdAt:string;
modifiedAt:string;
phoneNumber:string;
subaccount:internal;
subaccount:string;
verificationUuid:string;
}

Expand Down Expand Up @@ -54,7 +54,7 @@ export class VerifyInterface extends PlivoResourceInterface {

getVerifiedCallerId(phoneNumber: string): Promise < GetVerifiedCallerIdResponse > ;

deleteVerifiedCallerId(phoneNumber: string): Promise < > ;
deleteVerifiedCallerId(phoneNumber: string): Promise < any > ;
}
import {
PlivoResource,
Expand Down
4 changes: 2 additions & 2 deletions types/rest/client-test.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class Client {
hostedMessagingNumber: HostedMessagingNumberInterface;
maskingSession: MaskingSessionInterface;
tollfreeVerification: TollfreeVerificationInterface;
verifyCallerId: VerifyCallerIdInterface;
verify: VerifyInterface;
}
/**
* Plivo API client which can be used to access the Plivo APIs.
Expand Down Expand Up @@ -48,5 +48,5 @@ import { LOAInterface } from "../resources/loa.js";
import { HostedMessagingNumberInterface } from "../resources/hostedMessagingNumber.js";
import { MaskingSessionInterface } from "../resources/maskingSession.js";
import { TollfreeVerificationInterface } from "../resources/tollfree_verification.js";
import { VerifyCallerIdInterface } from "../resources/verifyCallerId.js";
import { VerifyInterface } from "../resources/verifyCallerId.js";

5 changes: 2 additions & 3 deletions types/rest/client.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class Client {
hostedMessagingNumber: HostedMessagingNumberInterface;
maskingSession:MaskingSessionInterface;
tollfreeVerification: TollfreeVerificationInterface;
verifyCallerId:VerifyCallerIdInterface;
verify:VerifyInterface;
toJSON(...args: any[]): any;
}
/**
Expand Down Expand Up @@ -70,6 +70,5 @@ import { LOAInterface } from "../resources/loa";
import { HostedMessagingNumberInterface } from "../resources/hostedMessagingNumber";
import { MaskingSessionInterface } from "../resources/maskingSession.js";
import { TollfreeVerificationInterface } from "../resources/tollfree_verification.js";
import { VerifyCallerIdInterface } from "../resources/verifyCallerId.js";

import { VerifyInterface } from "../resources/verifyCallerId.js";

Loading