Adds error detail for list and get campaign #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantjha-plivo
requested review from
narayana-plivo,
msk-plivo and
rajneeshkatkam-plivo
msk-plivo
approved these changes
Nov 29, 2023
rajneeshkatkam-plivo
approved these changes
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 35 35
Lines 2178 2178
=======================================
Hits 1547 1547
Misses 566 566
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vishesh-plivo
added a commit
that referenced
this pull request
Jan 30, 2024
* VT-5031: Number Masking Implementation (#156) * VT-5031: Number Masking Implementation * VT-5031: Implementing review comments * VT-6047 GoLang SDK implementation for Number Masking - Number Masking Phase2 and Private Beta changes * renamed fixture file * added masking session code separately outside calls * Fixed UTs * Fixed UTs * added sdk versioning * added sdk versioning --------- Co-authored-by: abinaya-plivo <[email protected]> * SMS-6010: Add DLT Params to Send and Get Message APIs (#178) * SMS-6010: Add DLT Params to Send and Get Message APIs * Version update * SMS-6060 WhatsApp message support in Go SDK (#179) * SMS-6060 WhatsApp message support in Go SDK * SMS-6060 adding proper template validation * SMS-6060 adding go.mod and go.sum * SMS-6060 updating go.mod and go.sum * SMS-6060 adding unit test and version bump * SMS-6060 update log * update log * SMS-6060 go mod and go sum change * go sum change * SMS-6060 go validitor version downgarde * SMS-6060 go universal-translator * version upgrade * SMS-6060 version upgrade changes * SMS-6060 changing currency and datetime model * SMS-6060 downgrading version * SMS-6060 updating CHANGELOG.md * SMS-6060 adding versioning and unit tests * updating Changelog.md file * updating Changelog.md file * SMS-6063: Go SDK for Verify Session APIs (#180) * Added create and get functions for verify go sdk * Added list function (without query params) for verify go sdk * Added validate function for verify go sdk * List function name changes * List function query params added * Added testcases for verify function sdks * Updated the version * Updated the changelog * Name updated * version added * Subaccount param added * updated the version * SMS-6066 - adding new param on mdr object (#183) * adding new param on mdr object * updated date --------- Co-authored-by: renoldthomas-plivo <[email protected]> * import campaign support (#184) * import campaign support * brand id filter fix * version update * remove space --------- Co-authored-by: renoldthomas-plivo <[email protected]> * Verify caller ID for outbound voice calls - Go SDK changes (#187) * Verify caller ID for outbound voice calls - Go SDK changes * fixed response structure * added versions * SMS-6099: Added meta data for List Brand, Campaign, Profile (#186) * Added meta data for List Brand, Campaign, Profile * Test commit * Test commit removed * Added total_count field to meta data for campaign and brand list response * Updating version * version update --------- Co-authored-by: renoldthomas-plivo <[email protected]> * TF verification changes in go sdk (#188) * TF verification changes in go sdk * Adding numberAPI changes and UTC for TF Verification APIs * Changing parameter names * Removing error in response structs * Adding _ in list API params * Changing field names * Removing _ from function names * TF verification changes in go sdk * Adding numberAPI changes and UTC for TF Verification APIs * Changing parameter names * Removing error in response structs * Adding _ in list API params * Changing field names * Removing _ from function names * Rebasing from master * Adding another filter TollFreeSMSVerificationOrderStatus * Correcting TF create response * bump version * refactored field names --------- Co-authored-by: kalyan-plivo <[email protected]> Co-authored-by: kapilp93 <[email protected]> * Added registration_status filter to Go SDK (#189) * SMS-6495 Ppk Bug Fix (#191) * SMS-6495 Ppk Bug Fix * Changelog and version updated * Adds error detail for list and get campaign (#190) * add error details for list and get campaign * field type change * Added param to GET/LIST Campaign APIs (#192) * added param to GET/LIST Campaign APIs * Update CHANGELOG.md --------- Co-authored-by: Thumpala Vinay Kumar <[email protected]> Co-authored-by: Renold Jose Thomas <[email protected]> * paramAddedInSpeakApi (#193) * paramAddedInSpeakApi * callbackUrl * callback * New parameter `create_mpc_if_alone` in MPC Add Participant API (#195) * New parameter `create_mpc_if_alone` in MPC Add Participant API * param name change * parameter name change * Version commit * changelog update * changes --------- Co-authored-by: eniyavan <[email protected]> --------- Co-authored-by: prashantp-plivo <[email protected]> Co-authored-by: abinaya-plivo <[email protected]> Co-authored-by: Mohsin Mamoon Hafiz <[email protected]> Co-authored-by: Kaushik <[email protected]> Co-authored-by: Rajneesh Katkam <[email protected]> Co-authored-by: Narayana Shanbhog <[email protected]> Co-authored-by: renoldthomas-plivo <[email protected]> Co-authored-by: Abinaya-plivo <[email protected]> Co-authored-by: Aditya Gupta <[email protected]> Co-authored-by: kalyan-plivo <[email protected]> Co-authored-by: kapilp93 <[email protected]> Co-authored-by: eshangupta-plivo <[email protected]> Co-authored-by: Prashant <[email protected]> Co-authored-by: vinaykumar-plivo <[email protected]> Co-authored-by: Thumpala Vinay Kumar <[email protected]> Co-authored-by: ajay-plivo <[email protected]> Co-authored-by: eniyavan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.