Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small optimization of splat sorting #268

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Small optimization of splat sorting #268

merged 1 commit into from
Oct 30, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 30, 2023 •
edited
Loading

  • in the final pass of the radix sort, do not update temp array followed by copy to target array, but generate target array directly as temp array is no longer needed to be sorted.
  • This saves about 10% of worker time.

@mvaligursky mvaligursky self-assigned this Oct 30, 2023
@mvaligursky mvaligursky merged commit 3bfba26 into main Oct 30, 2023
2 checks passed
@mvaligursky mvaligursky deleted the mv-optimize-splat-sort branch October 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck