Removing the auto upload of support bundle code #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedantjoshi84
requested review from
cruizen,
mithilarun,
anmolsachan,
iamajohn,
psarwate,
srinivaschavan,
srm6867,
jayanth-tjvrr,
manasabsv26 and
deepaksahu-pf9
mithilarun
reviewed
Jul 19, 2024
|
Can you update the tests too? We actually have tests that test upload to s3 and they are failing now :-) https://github.com/platform9/pf9ctl/actions/runs/10034316801/job/27728661832?pr=378 |
mithilarun
previously approved these changes
Jul 22, 2024
vedantjoshi84
changed the title
mithilarun
approved these changes
Jul 23, 2024
srinivaschavan
approved these changes
Jul 24, 2024
cruizen
approved these changes
Jul 24, 2024
|
@vedantjoshi84 , can you merge this, update/ release pf9ctl and use the new pf9ctl in SMCP 5.10.1 (patch for Sambanova? |
|
@vedantjoshi84 #377 will solve the 2 open security issues flagged by dependabot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE(S):
PMK-6512
SUMMARY
The s3 bucket for the support bundle upload is disabled because of #incident351, so removing the auto upload of the generated support bundle to s3.
ISSUE TYPE
IMPACTED FEATURES/COMPONENTS:
pmk, pf9ctl
RELATED ISSUE(S):
DEPENDS ON:
TESTING DONE
Automated
Manual
Reviewers