Adding log statement to include the hostname on which a particular op… #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupbarve
approved these changes
May 13, 2021
| @@ -42,6 +42,8 @@ func (c LocalExecutor) RunWithStdout(name string, args ...string) (string, error | |||
| // RemoteExecutor as the name implies runs commands usign SSH on remote host | |||
| type RemoteExecutor struct { | |||
| Client ssh.Client | |||
| // host name for debugging purposes | |||
There was a problem hiding this comment.
nit :
This is generic enough and can be used to log info other than host name. I am anticipating this functionality to get updated for ssh tunneling as well and we may want to log that info too.
Maybe just update the comment to indicate so ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a log statement to make it easy for customers to debug which host failed in a multi-threaded environment.
I am still testing it end to end, sending it out for a quick review