-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
보상 정산 방식 리팩토링 #60
Open
ipdae
wants to merge
20
commits into
main
Choose a base branch
from
bugfix/issue-59
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
보상 정산 방식 리팩토링 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ipdae
commented
Sep 20, 2024
- raw bulk insert sql을 통해 성능 향상
- tx 서명에 headless 의존성을 제거하고 직접 서명
- 기존 정산방식에서 전체목록을 직접 생성하던 방식대신 스케쥴러를 통해 DB에 Transaction, WorldBoss, WorldBossRewardAmount 모델을 정해진 크기만큼 나눠서 생성하고 모든 모델이 준비되면 슬랙에 csv로 결과를 업로드하도록 변경
U-lis
reviewed
Sep 23, 2024
], | ||
] | ||
) | ||
if memo is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function parameter says memo
is mandatory.
If memo is really nullable, the function parameter can be nullable like memo: Optional[str] = None
임시배포 이후 중간 순위가 비는 현상이 발생. 조사 후 추가 수정해서 다시 리뷰요청하겠습니다. |
ipdae
force-pushed
the
bugfix/issue-59
branch
from
September 26, 2024 04:49
cb53fcb
to
1ea3b56
Compare
아래와 같은 처리들이 추가됐습니다. 리뷰 부탁드립니다. @U-lis
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.