#10090 fix conflicts and rebased

pkp · Oct 2, 2024 · b09c81b · b09c81b
1 parent 3fa4c3c
commit b09c81b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/classes/stageAssignment/StageAssignment.php b/classes/stageAssignment/StageAssignment.php
@@ -145,4 +145,15 @@ public function scopeWithContextId(Builder $query, ?int $contextId): Builder
                 ->where('submissions.context_id', $contextId);
         });
     }
+
+
+    /**
+     * Accessor for the userId attribute.
+     *
+     * @return int The user_id as an integer.
+     */
+    public function getUserIdAttribute(): int
+    {
+        return (int) $this->attributes['user_id'];
+    }
 }
diff --git a/controllers/grid/queries/form/QueryForm.php b/controllers/grid/queries/form/QueryForm.php
@@ -327,14 +327,11 @@ public function fetch($request, $template = null, $display = false, $actionArgs
             // if current user is an anonymous reviewer, filter out authors
             foreach ($reviewAssignments as $reviewAssignment) {
                 if ($reviewAssignment->getReviewerId() == $user->getId()) {
-                    if ($reviewAssignment->getReviewMethod() != ReviewAssignment::SUBMISSION_REVIEW_METHOD_OPEN) {
-                        // Replaces StageAssignmentDAO::getBySubmissionAndRoleId
-                        $excludeUsers = StageAssignment::withSubmissionIds([$query->assocId])
+                    if ($reviewAssignment->getReviewMethod() == ReviewAssignment::SUBMISSION_REVIEW_METHOD_DOUBLEANONYMOUS) {
+                        $stageAssignments = StageAssignment::withSubmissionIds([$query->assocId])
                             ->withRoleIds([Role::ROLE_ID_AUTHOR])
-                            ->withUserId($user->getId())
-                            ->get()
-                            ->pluck('userId')
-                            ->all();
+                            ->get();
+                        $excludeUsers = $stageAssignments->pluck('userId')->all();
                     }
                 }
             }