Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing dev docs to GitHub Actions #1251

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

kaitlinnewson
Copy link
Member

Update docs from Travis to GitHub Actions. Closes #1247.

@kaitlinnewson kaitlinnewson linked an issue Sep 25, 2024 that may be closed by this pull request
@kaitlinnewson
Copy link
Member Author

Hi @withanage, could you give this update to the testing docs a review? I've only changed parts referencing Travis, and haven't updated anything about Cypress (but if you see other things that need to be updated, let me know and I can try to incorporate those too).

Here's the current outdated live version of the guide for reference.

@withanage
Copy link
Member

hi @kaitlinnewson
thanks for that, i will review the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@withanage I've noticed that this "Download artifacts" link at the top of a PR when a test fails does not always appear consistently - do you know why that is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaitlinnewson actually, github should generate them automatically, do you have an example, where you could not see the Download link ?

Copy link
Member Author

@kaitlinnewson kaitlinnewson Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@withanage Nevermind, I think I see the confusion - this link to artifacts at the top only appears on the .../checks page, but then does not appear if you click on a job (but can be accessed in the build log instead). For example:

@kaitlinnewson
Copy link
Member Author

@withanage Any additional feedback on these docs updates?

@withanage
Copy link
Member

@kaitlinnewson
Looks great! Please go ahead with merge

@kaitlinnewson kaitlinnewson merged commit 4d4a729 into main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update testing documentation to GitHub Actions
2 participants