Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9169 idb log durability and timeout changes #9177

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Sep 19, 2024

What does this PR do?

Discussion

  • Tested by intentionally removing db.close() methods everywhere, and by adding an infinite loop in sweep

Future Work

The rest of the checklist in #9169

Checklist

  • This PR requires a security review
  • This PR introduces a new library: double check it's MIT/Apache2/permissively licensed
  • This PR requires a node/npm version update: let the team know on #engineering
  • This PR requires a documentation change (link to old docs)
  • This PR requires a tutorial update (link to old tutorials)
  • This PR requires a feature flag
  • This PR requires a environment variable change
  • Added jest or playwright tests and/or storybook stories

For more information on our expectations for the PR process, see the
code review principles doc

@fungairino fungairino self-assigned this Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (8318d74) to head (cc518ff).
Report is 304 commits behind head on main.

Files with missing lines Patch % Lines
src/telemetry/logging.ts 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9177      +/-   ##
==========================================
+ Coverage   74.24%   74.78%   +0.53%     
==========================================
  Files        1332     1360      +28     
  Lines       40817    41895    +1078     
  Branches     7634     7827     +193     
==========================================
+ Hits        30306    31330    +1024     
- Misses      10511    10565      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 19, 2024

Playwright test results

passed  124 passed
flaky  4 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  132 tests across 44 suites
duration  12 minutes, 12 seconds
commit  cc518ff
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/copyMod.spec.ts › copying a mod that uses the PixieBrix API is copied correctly
msedge › tests/pageEditor/copyMod.spec.ts › copying a mod that uses the PixieBrix API is copied correctly

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@fungairino fungairino changed the title 9169 durability and timeout 9169 idb log durability and timeout changes Sep 19, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fungairino fungairino enabled auto-merge (squash) September 19, 2024 18:21
@fungairino fungairino merged commit 839fa1d into main Sep 19, 2024
20 checks passed
@fungairino fungairino deleted the 9169-durability-and-timeout branch September 19, 2024 18:37
grahamlangford pushed a commit that referenced this pull request Sep 20, 2024
* adding timeout to sweep and blocked handling

* improve inclusivity
@grahamlangford grahamlangford added this to the 2.1.2 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants