-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Organizations to Teams in the data model #9170
Conversation
…create-organization-data-model
…9131-slice-3-deactivate-all-team-mods-not-in-a-deployment
…/pixiebrix-extension into 9131-slice-3-deactivate-all-team-mods-not-in-a-deployment
…9131-slice-3-deactivate-all-team-mods-not-in-a-deployment
…rename-orgs-teams
…rename-orgs-teams
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9170 +/- ##
==========================================
+ Coverage 74.24% 74.79% +0.54%
==========================================
Files 1332 1360 +28
Lines 40817 41880 +1063
Branches 7634 7823 +189
==========================================
+ Hits 30306 31325 +1019
- Misses 10511 10555 +44 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
</tr> | ||
), | ||
)} | ||
{sortBy(organizations, (x) => x.teamName).map((organization) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: opportunity to rename these local variables. Makes sense if you want to keep the scope of this to types and data model though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was, but I went ahead and did this renaming real quick. There are definitely some opportunities for follow-on renaming work. Such as renaming the api hooks (useGetOrganizations -> useGetTeams for example)
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
* refactor/extract duplicated functions; create syncActivatedModCOmponents * run team trial updater in the background * fix modUpdater test, create deactivateMod test * create initial data model * finish implementing transformers * fix typing * remove dead code * switch back to LegacyUserRole and change organization.role to organization.isAdmin * remove dead code; use UserRole * remove the lifted value from Organzation * rename OrganizationMembers -> OrganizationMemberships * member -> membership * update typings * adds deactivateModComponent tests * organization -> team * rename all service layer level organization types to ream * rename local variables
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc