#9150 Introduce SandboxInjectionError and increase sandbox timeouts to 5s

[mnholtz]

What does this PR do?

• Part of [Spike] render_nunjucks error spike #9150
• While we haven't identified root cause of [Spike] render_nunjucks error spike #9150, this PR
  1. Increases the timeout associated with injecting & sending messages to the sandbox from 3s to 5s (to address the hypothesis that this error is happening on slow machines) and
  2. Introduces a more specific SandboxInjectionError to be explicit about the cause of the sandbox errors we are seeing (to rule out the less-strong hypothesis that the sandbox is getting removed from the page more often than before)

Discussion

• See notion document for context and bug triage notes https://www.notion.so/pixiebrix/Nunjucks-Error-Spike-0283abe59c6a48ad96f5f84715516ec3?showMoveTo=true&saveParent=true

[codecov]

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.80%. Comparing base (8318d74) to head (a79c9bb).
Report is 299 commits behind head on main.

Files with missing lines	Patch %	Lines
src/sandbox/messenger/api.ts	0.00%	8 Missing ⚠️
src/utils/injectIframe.tsx	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9168      +/-   ##
==========================================
+ Coverage   74.24%   74.80%   +0.55%     
==========================================
  Files        1332     1360      +28     
  Lines       40817    41886    +1069     
  Branches     7634     7826     +192     
==========================================
+ Hits        30306    31331    +1025     
- Misses      10511    10555      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Playwright test results

 125 passed
 3 flaky
 4 skipped

Details

 Open report ↗︎
 132 tests across 44 suites
 11 minutes, 55 seconds
 a79c9bb
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[mnholtz]

We might want to consider increasing MAX_RETRIES as well.

@grahamlangford if we can get this into a beta build & have users try this out before we release, that would be ideal. We were seeing a spike in this error in the beta build for the last release. Might give us an opportunity to tweak our approach before releasing

[twschiller]

NIT: prefer override. See examples:

pixiebrix-extension/src/bricks/errors.ts

Line 34 in e05acf0

override name = "HeadlessModeError";

override name = "SandboxInjectionError";

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.