#9103 No update button for pinned deployments #9140
Conversation
mnholtz
changed the title
| } | ||
|
|
||
| if (semver.lt(current.version, activated.version)) { | ||
| // TODO: In what case would the current version be less than the activated version? |
There was a problem hiding this comment.
When refactoring, this logic came to my attention 🤔 Anyone know what this could be handling?
There was a problem hiding this comment.
Probably no case, just completionist
There was a problem hiding this comment.
Sort-of-related refactor (I initially though my logic would go here)
mnholtz
requested review from
grahamlangford,
BLoe,
twschiller and
fungairino
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9140 +/- ##
==========================================
+ Coverage 74.24% 74.78% +0.53%
==========================================
Files 1332 1349 +17
Lines 40817 41745 +928
Branches 7634 7787 +153
==========================================
+ Hits 30306 31220 +914
- Misses 10511 10525 +14 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Flaky testsmsedge › tests/extensionConsole/activation.spec.ts › can activate a mod with a database Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
…ate personal deployment feature
| @@ -88,7 +90,7 @@ const Status: React.VoidFunctionComponent<{ | |||
| ); | |||
| } | |||
|
|
|||
| if (hasUpdate && showReactivate) { | |||
| if (hasUpdate && showReactivate && !(sharingSource.type === "Deployment")) { | |||
| return ( | ||
| <Button | ||
| size="sm" | ||
| variant="info" | ||
| className="text-nowrap" |
There was a problem hiding this comment.
Unrelated fix to the wrapping issue on the Update button
| @@ -87,6 +87,44 @@ describe("Status", () => { | |||
| expect(screen.getByText("Update")).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it("doesn't show update button for deployments", () => { | |||
There was a problem hiding this comment.
nit: I'd be more specific and name this test "doesn't show update button for team deployments"
|
When the PR is merged, the first loom link found on this PR will be posted to |
mnholtz
deleted the
feature/9103_no_update_button_for_pinned_deployments
branch
What does this PR do?
Demo
https://www.loom.com/share/a16175dd5bb945309f325b110ef78559