Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Remove standalone mods phase 5 - slices 1+2 #9123

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Feature - Remove standalone mods phase 5 - slices 1+2 #9123

wants to merge 55 commits into from

Commits on Sep 12, 2024

  1. when saving mod, if inner id, show create mod modal, and remove save … 

    …from components
    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d87f5a5 View commit details
    Browse the repository at this point in the history

  2. rename reset to clear changes

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8675fa3 View commit details
    Browse the repository at this point in the history

  3. add test

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a1277bb View commit details
    Browse the repository at this point in the history

  4. rename component

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    543fe0f View commit details
    Browse the repository at this point in the history

  5. change label

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2dbbbf7 View commit details
    Browse the repository at this point in the history

  6. implement save logic for unsaved, temp mods

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    dd7a025 View commit details
    Browse the repository at this point in the history

  7. fix save mod test

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f48bbe7 View commit details
    Browse the repository at this point in the history

  8. fix tests

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fb9e705 View commit details
    Browse the repository at this point in the history

  9. make source parts required

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    45f85b1 View commit details
    Browse the repository at this point in the history

  10. undo input changes

    Ben Loe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6775e9f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. fix action menus and cleanup dead code

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    61432f3 View commit details
    Browse the repository at this point in the history

  2. cleanup

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5598eca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/remove-standalone-mods-phase-5

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7da562d View commit details
    Browse the repository at this point in the history

  4. fix tests and restore saveasnewmodmodal

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    aecc803 View commit details
    Browse the repository at this point in the history

  5. fix remaining tests

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6ac0195 View commit details
    Browse the repository at this point in the history

  6. fix dead code

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b114821 View commit details
    Browse the repository at this point in the history

  7. more dead code cleanup

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c441731 View commit details
    Browse the repository at this point in the history

  8. add more timeout to activation spec

    Ben Loe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b33eab7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. fix tests

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f54bf48 View commit details
    Browse the repository at this point in the history

  2. fix mod lifecycle tests

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dd8c519 View commit details
    Browse the repository at this point in the history

  3. fix add new mod with starter bricks tests

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    87de61b View commit details
    Browse the repository at this point in the history

  4. fix starter brick spec, tests, update snapshots

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c168125 View commit details
    Browse the repository at this point in the history

  5. fix brickActions test

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3401671 View commit details
    Browse the repository at this point in the history

  6. fix brickConfiguration test

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7a4799a View commit details
    Browse the repository at this point in the history

  7. fix saveMod test

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d7f5943 View commit details
    Browse the repository at this point in the history

  8. fix doNotCloseSidebarOnSave regression test

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    33762b8 View commit details
    Browse the repository at this point in the history

  9. add snapshot

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    66111eb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into feature/remove-standalone-mods-phase-5

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bec1f00 View commit details
    Browse the repository at this point in the history

  11. update action disabled and icons

    Ben Loe committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3189624 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. refactor mod listing panel sub components and implement some of the s… 

    …teps for mod actions
    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6c0dab6 View commit details
    Browse the repository at this point in the history

  2. some PR feedback and comment fixes

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5f8f959 View commit details
    Browse the repository at this point in the history

  3. pr feedback and fix filter

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    399402e View commit details
    Browse the repository at this point in the history

  4. some more pr feedback fixes

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bae2617 View commit details
    Browse the repository at this point in the history

  5. fix filter tests and make create modal more clear

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c0130e1 View commit details
    Browse the repository at this point in the history

  6. fix dead code

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c540f3d View commit details
    Browse the repository at this point in the history

  7. wip playwright tests modActions, some PR feedback

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4e00e76 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feature/remove-standalone-mods-phase-5

    Ben Loe committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    82e438a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. first mod actions test passing

    Ben Loe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5f9dcaf View commit details
    Browse the repository at this point in the history

  2. add snapshots and more test fixes for saved mod actions

    Ben Loe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f241aec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/remove-standalone-mods-phase-5

    Ben Loe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1ace8dd View commit details
    Browse the repository at this point in the history

  4. add modUuid to saveMod to prevent test collision

    @mnholtz
    mnholtz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c5b983c View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. show save button on all mods

    Ben Loe committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6eef444 View commit details
    Browse the repository at this point in the history

  2. fix 'add starter brick to mod' test

    @mnholtz
    mnholtz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5ff334 View commit details
    Browse the repository at this point in the history

  3. fix editorStorage tests

    @grahamlangford
    grahamlangford committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    038569b View commit details
    Browse the repository at this point in the history

  4. fix deactivateModComponent tests

    @grahamlangford
    grahamlangford committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    903c7fa View commit details
    Browse the repository at this point in the history

  5. avoid duplicated mod name for new mod when moving mod component

    @mnholtz
    mnholtz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b1ac39c View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. rename factory

    @grahamlangford
    grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fd06ccf View commit details
    Browse the repository at this point in the history

  2. Improve typing for api paths and update playwright documentation (#9167) 

    * wip

* better paths type and updated readme

* update types

* fix type error
    @fungairino @grahamlangford
    fungairino authored and grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7e556c0 View commit details
    Browse the repository at this point in the history

  3. * Fix EllipsisMenu wrapping to next line 

    * Update snapshots
    @johnnymetz @grahamlangford
    johnnymetz authored and grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b117ee1 View commit details
    Browse the repository at this point in the history

  4. 9169 indexeddb logging disable flag + more debug logging (#9174) 

    * log successful trigger runs to debug instead of info

* update comment

* added logging and a quick rename

* disable idb logging feature flag

* fix test

---------

Co-authored-by: Graham Langford <[email protected]>
    @fungairino @grahamlangford
    fungairino and grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4abbbcb View commit details
    Browse the repository at this point in the history

  5. Rename Organizations to Teams in the data model (#9170) 

    * refactor/extract duplicated functions; create syncActivatedModCOmponents

* run team trial updater in the background

* fix modUpdater test, create deactivateMod test

* create initial data model

* finish implementing transformers

* fix typing

* remove dead code

* switch back to LegacyUserRole and change organization.role to organization.isAdmin

* remove dead code; use UserRole

* remove the lifted value from Organzation

* rename OrganizationMembers -> OrganizationMemberships

* member -> membership

* update typings

* adds deactivateModComponent tests

* organization -> team

* rename all service layer level organization types to ream

* rename local variables
    @grahamlangford
    grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    847b427 View commit details
    Browse the repository at this point in the history

  6. 9169 idb log durability and timeout changes (#9177) 

    * adding timeout to sweep and blocked handling

* improve inclusivity
    @fungairino @grahamlangford
    fungairino authored and grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6525803 View commit details
    Browse the repository at this point in the history

  7. fix snapshots

    @grahamlangford
    grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1f234ce View commit details
    Browse the repository at this point in the history

  8. update snapshots

    @grahamlangford
    grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    10c511f View commit details
    Browse the repository at this point in the history

  9. merge main

    @grahamlangford
    grahamlangford committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e4f66ec View commit details
    Browse the repository at this point in the history