-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiln validate resource type allow list #501
Open
jajita
wants to merge
7
commits into
main
Choose a base branch
from
kiln-validate-resource-type-allow-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
466b4d5
Add flag for kiln validate to specify allow list for release source t…
jajita fdea504
feat(cargo): allow configuration of Validate to check allow list for …
crhntr a9ba322
fix: add langauge annotation to test value
crhntr 35d3b6f
test(commands): add test for empty release_source type allow list
crhntr 73b3d5b
fix: remove focus
crhntr 084efc1
feat: add release_source field validation
crhntr bc63749
fix(cargo): add Options constructor
crhntr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
package commands_test | ||
|
||
import ( | ||
"io" | ||
|
||
. "github.com/onsi/ginkgo" | ||
. "github.com/onsi/gomega" | ||
|
||
"github.com/go-git/go-billy/v5" | ||
"github.com/go-git/go-billy/v5/memfs" | ||
|
||
"github.com/pivotal-cf/kiln/internal/commands" | ||
) | ||
|
||
var _ = Describe("validate", func() { | ||
var ( | ||
validate commands.Validate | ||
directory billy.Filesystem | ||
) | ||
|
||
BeforeEach(func() { | ||
directory = memfs.New() | ||
}) | ||
|
||
JustBeforeEach(func() { | ||
validate = commands.NewValidate(directory) | ||
}) | ||
|
||
When("the kilnfile has two release_sources", func() { | ||
BeforeEach(func() { | ||
f, err := directory.Create("Kilnfile") | ||
Expect(err).NotTo(HaveOccurred()) | ||
// language=yaml | ||
_, _ = io.WriteString(f, `--- | ||
release_sources: | ||
- type: "bosh.io" | ||
- type: "github" | ||
`) | ||
_ = f.Close() | ||
}) | ||
|
||
BeforeEach(func() { | ||
f, err := directory.Create("Kilnfile.lock") | ||
Expect(err).NotTo(HaveOccurred()) | ||
_ = f.Close() | ||
}) | ||
|
||
When("both types are in the allow list", func() { | ||
It("it does fail", func() { | ||
err := validate.Execute([]string{ | ||
"--allow-release-source-type=bosh.io", | ||
"--allow-release-source-type=github", | ||
}) | ||
Expect(err).NotTo(HaveOccurred()) | ||
}) | ||
}) | ||
When("both one of the types is not in the allow list", func() { | ||
It("it does fail", func() { | ||
err := validate.Execute([]string{ | ||
"--allow-release-source-type=bosh.io", | ||
}) | ||
Expect(err).To(MatchError(ContainSubstring("release source type not allowed: github"))) | ||
}) | ||
}) | ||
When("the allow list is empty", func() { | ||
It("it does not fail", func() { | ||
err := validate.Execute([]string{}) | ||
Expect(err).NotTo(HaveOccurred()) | ||
}) | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we append to the list instead of replacing?