test: switch to vitest #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zOadT
force-pushed
the
simplify-env-handling
branch
from
41ddde1
to
5c38842
Compare
|
When you directly use a global variable and it is undefined, it throws an exception. So the safe way to use them is to first check if they are defined, or do something like process.env.NAME. |
shakiba
approved these changes
Aug 6, 2023
zOadT
force-pushed
the
simplify-env-handling
branch
from
4d52354
to
6684006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there is a reason to use the
_ASSERTanymore since we switched to TypeScript. In the worst case the variables areundefinedwhich should still be fine for us.EDIT: Turns out tests can be a problem, but I guess it's a good idea to switch to vitest now anyway? 😅