Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change resource key logic for k8s" #4997

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jun 25, 2024

Reverts #4916

After v0.47.3-rc0 was released and verified, I found some issues to be solved. #4994 #4981 #4995 #4996
It takes some more time and prevents the new release.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 4.91803% with 58 lines in your changes missing coverage. Please review.

Project coverage is 22.09%. Comparing base (513a28d) to head (f625081).

Current head f625081 differs from pull request most recent head 4cd8f74

Please upload reports for the commit 4cd8f74 to get more accurate results.

Files Patch % Lines
pkg/app/piped/executor/kubernetes/kubernetes.go 0.00% 25 Missing ⚠️
...kg/app/piped/platformprovider/kubernetes/loader.go 0.00% 15 Missing ⚠️
pkg/app/piped/driftdetector/kubernetes/detector.go 0.00% 5 Missing ⚠️
pkg/app/piped/planner/kubernetes/kubernetes.go 0.00% 3 Missing ⚠️
pkg/app/piped/planpreview/builder.go 0.00% 3 Missing ⚠️
pkg/app/piped/planpreview/kubernetesdiff.go 0.00% 3 Missing ⚠️
pkg/app/piped/executor/kubernetes/baseline.go 0.00% 1 Missing ⚠️
pkg/app/piped/executor/kubernetes/primary.go 0.00% 1 Missing ⚠️
pkg/app/piped/executor/kubernetes/rollback.go 0.00% 1 Missing ⚠️
...g/app/piped/platformprovider/kubernetes/applier.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4997      +/-   ##
==========================================
+ Coverage   22.05%   22.09%   +0.03%     
==========================================
  Files         519      518       -1     
  Lines       57247    57109     -138     
==========================================
- Hits        12627    12619       -8     
+ Misses      43598    43469     -129     
+ Partials     1022     1021       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 8129078.

Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo force-pushed the revert-4916-change-resource-key-logic-for-k8s branch from 115683f to f625081 Compare June 25, 2024 14:58
@ffjlabo
Copy link
Member Author

ffjlabo commented Jun 25, 2024

force pushed for just a signed off

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investigating.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go 👍

@ffjlabo ffjlabo enabled auto-merge (squash) June 26, 2024 06:05
@ffjlabo ffjlabo merged commit 9a7c8cd into master Jun 26, 2024
24 of 26 checks passed
@ffjlabo ffjlabo deleted the revert-4916-change-resource-key-logic-for-k8s branch June 26, 2024 06:09
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
hungran pushed a commit to hungran/pipecd that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants