piped panics when using K8S_PRIMARY_ROLLOUT
with spec.planner.alwaysPipelineSync: true
and its stage option prune:true
on v0.47.3-rc0
#4996
Labels
kind/bug
Something isn't working
What happened:
When adding the k8s app with app.pipecd.yaml which has
spec.planner.alwaysPipelineSync: true
andK8S_PRIMARY_ROLLOUT
with the optionprune:true
, piped fails with panic like this↓.The piped keeps failing until it is canceled on the UI.
K8S_PRIMARY_ROLLOUT requires the previous running commit, which was deployed previously when prune option is enabled.
pipecd/pkg/app/piped/executor/kubernetes/primary.go
Lines 141 to 165 in 8129078
But there isn't the one when adding the app first.
So e.RunningDSP is nil and causes panic.
This bug is created by the fix in #4916
What you expected to happen:
It should fail with an error on the stage when first adding the app and deploying it as PipelineSync.
How to reproduce it:
Create and add k8s app below.
app.pipecd.yaml
deployment.yaml
service.yaml
Environment:
piped
version: v0.47.3-rc0control-plane
version:The text was updated successfully, but these errors were encountered: