You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When deploying a namespaced resource with spec.input.namespace in the app.piped.yaml, the namespace in the resource key isn't correct.
For example, I deployed the Deployment resource with the app.pipecd.yaml which has spec.input.namespace: test using v0.47.3-rc0.
I expected the resource key as apps/v1:Deployment:test:namescoped-and-clusterrole-with-ns. But it is apps/v1:Deployment::namescoped-and-clusterrole-with-ns, which doesn't have a namespace.
The resource key is used to prune unused resources so should be the correct value.
What you expected to happen:
The resource key when reading manifest from git repo should be apps/v1:Deployment:test:namescoped-and-clusterrole-with-ns
How to reproduce it:
For example, deploy a Deployment resource with spec.input.namespace:test in the app.piped.yaml.
app,pipecd.yaml↓
apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
name: namescoped-and-clusterrole-with-ns
input:
namespace: test
labels:
env: namescoped-and-clusterrole-with-ns
team: product
quickSync:
prune: true
description: |
This is a test app for clusterrole. Especially for testing the prune on QuickSync.
What happened:
When deploying a namespaced resource with spec.input.namespace in the app.piped.yaml, the namespace in the resource key isn't correct.
For example, I deployed the Deployment resource with the app.pipecd.yaml which has
spec.input.namespace: test
using v0.47.3-rc0.I expected the resource key as
apps/v1:Deployment:test:namescoped-and-clusterrole-with-ns
. But it isapps/v1:Deployment::namescoped-and-clusterrole-with-ns
, which doesn't have a namespace.The resource key is used to prune unused resources so should be the correct value.
What you expected to happen:
The resource key when reading manifest from git repo should be
apps/v1:Deployment:test:namescoped-and-clusterrole-with-ns
How to reproduce it:
For example, deploy a Deployment resource with
spec.input.namespace:test
in the app.piped.yaml.app,pipecd.yaml↓
deployment.yaml
Environment:
piped
version: v0.47.3-rc0control-plane
version:The text was updated successfully, but these errors were encountered: