Type fixes #522
Merged
Type fixes #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/MissingExportEquals.md This required deleting some type tests. Since the type tests are testing things that aren't exported, this may be acceptable.
It's offered by the TypeScript types, but the JS didn't export it, which resulted in errors at runtime.
renovate bot
added a commit
to open-feature/playground
that referenced
this pull request
Jul 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`11.0.0` -> `11.2.2`](https://renovatebot.com/diffs/npm/pino-pretty/11.0.0/11.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v11.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.2) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.1...v11.2.2) #### What's Changed - Type fixes by [@​joshkel](https://togithub.com/joshkel) in [pinojs/pino-pretty#522 #### New Contributors - [@​joshkel](https://togithub.com/joshkel) made their first contribution in [pinojs/pino-pretty#522 **Full Changelog**: pinojs/pino-pretty@v11.2.1...v11.2.2 ### [`v11.2.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.1): v11 [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1) #### What's Changed - Fix: add missing useOnlyCustomProps options to type definitions by [@​pcdevil](https://togithub.com/pcdevil) in [pinojs/pino-pretty#514 #### New Contributors - [@​pcdevil](https://togithub.com/pcdevil) made their first contribution in [pinojs/pino-pretty#514 **Full Changelog**: pinojs/pino-pretty@v11.2.0...v11.2.1 ### [`v11.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0) #### What's Changed - fix: add injection of lacking arguments of customPrettifiers by [@​pasha-vuiko](https://togithub.com/pasha-vuiko) in [pinojs/pino-pretty#501 #### New Contributors - [@​pasha-vuiko](https://togithub.com/pasha-vuiko) made their first contribution in [pinojs/pino-pretty#501 **Full Changelog**: pinojs/pino-pretty@v11.1.0...v11.2.0 ### [`v11.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.1.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.0.0...v11.1.0) #### What's Changed - Bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#503 - Fix Object.create(null) by [@​chrisands](https://togithub.com/chrisands) in [pinojs/pino-pretty#507 - Bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#509 - Bump pino from 8.21.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino-pretty#510 - feat: automatically consume pino config when using pino@>=8.21.0 by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino-pretty#508 - fix: pass error-like objects ([#​505](https://togithub.com/pinojs/pino-pretty/issues/505)) by [@​aqemi](https://togithub.com/aqemi) in [pinojs/pino-pretty#506 - Add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino-pretty#511 - feat: Added exports color support in TTY by [@​synapse](https://togithub.com/synapse) in [pinojs/pino-pretty#513 #### New Contributors - [@​chrisands](https://togithub.com/chrisands) made their first contribution in [pinojs/pino-pretty#507 - [@​aqemi](https://togithub.com/aqemi) made their first contribution in [pinojs/pino-pretty#506 - [@​synapse](https://togithub.com/synapse) made their first contribution in [pinojs/pino-pretty#513 **Full Changelog**: pinojs/pino-pretty@v11.0.0...v11.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/playground). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
abhi-markan
added a commit
to UK-Export-Finance/mdm-api
that referenced
this pull request
Jul 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/lodash](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash)) | [`4.17.6` -> `4.17.7`](https://renovatebot.com/diffs/npm/@types%2flodash/4.17.6/4.17.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.14.10` -> `20.14.13`](https://renovatebot.com/diffs/npm/@types%2fnode/20.14.10/20.14.13) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-n](https://togithub.com/eslint-community/eslint-plugin-n) | [`17.9.0` -> `17.10.1`](https://renovatebot.com/diffs/npm/eslint-plugin-n/17.9.0/17.10.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`5.1.3` -> `5.2.1`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/5.1.3/5.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-unused-imports](https://togithub.com/sweepline/eslint-plugin-unused-imports) | [`4.0.0` -> `4.0.1`](https://renovatebot.com/diffs/npm/eslint-plugin-unused-imports/4.0.0/4.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [husky](https://togithub.com/typicode/husky) | [`9.0.11` -> `9.1.3`](https://renovatebot.com/diffs/npm/husky/9.0.11/9.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`11.2.1` -> `11.2.2`](https://renovatebot.com/diffs/npm/pino-pretty/11.2.1/11.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prettier](https://prettier.io) ([source](https://togithub.com/prettier/prettier)) | [`3.3.2` -> `3.3.3`](https://renovatebot.com/diffs/npm/prettier/3.3.2/3.3.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://togithub.com/kulshekhar/ts-jest)) | [`29.2.2` -> `29.2.3`](https://renovatebot.com/diffs/npm/ts-jest/29.2.2/29.2.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typeorm-extension](https://togithub.com/tada5hi/typeorm-extension) | [`3.5.1` -> `3.6.0`](https://renovatebot.com/diffs/npm/typeorm-extension/3.5.1/3.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/TypeScript)) | [`5.5.3` -> `5.5.4`](https://renovatebot.com/diffs/npm/typescript/5.5.3/5.5.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>eslint-community/eslint-plugin-n (eslint-plugin-n)</summary> ### [`v17.10.1`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#17101-2024-07-26) [Compare Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.10.0...v17.10.1) ##### 🩹 Fixes - Revert ts version (5.5 -> 5.4) ([#​317](https://togithub.com/eslint-community/eslint-plugin-n/issues/317)) ([3bee0d9](https://togithub.com/eslint-community/eslint-plugin-n/commit/3bee0d9b3d6b01c1dffb21aa0ca608045ae4aafd)) ### [`v17.10.0`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#17100-2024-07-26) [Compare Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.9.0...v17.10.0) ##### 🌟 Features - **no-unsupported:** Support node 20.16.0 ([73e2bed](https://togithub.com/eslint-community/eslint-plugin-n/commit/73e2bed2e76dc9382069268954ae894665f18538)) - **no-unsupported:** Support node 22.3.0 and 20.16.0 ([#​315](https://togithub.com/eslint-community/eslint-plugin-n/issues/315)) ([73e2bed](https://togithub.com/eslint-community/eslint-plugin-n/commit/73e2bed2e76dc9382069268954ae894665f18538)) - Update to node v22.4.0 ([#​310](https://togithub.com/eslint-community/eslint-plugin-n/issues/310)) ([f7a74eb](https://togithub.com/eslint-community/eslint-plugin-n/commit/f7a74eb147875d7e2125125863befe61d0be0614)), closes [#​308](https://togithub.com/eslint-community/eslint-plugin-n/issues/308) - Update to node v22.5.0 ([#​312](https://togithub.com/eslint-community/eslint-plugin-n/issues/312)) ([2539c9d](https://togithub.com/eslint-community/eslint-plugin-n/commit/2539c9deaa0c339b520dcd45ba4998dca6b678e3)) ##### 📚 Documentation - add clarifications to readme ([dbdfa8e](https://togithub.com/eslint-community/eslint-plugin-n/commit/dbdfa8e0abdeb96f2f843c4112cc43f16f2657ea)) - fix spacings in the example ([#​306](https://togithub.com/eslint-community/eslint-plugin-n/issues/306)) ([c092cd8](https://togithub.com/eslint-community/eslint-plugin-n/commit/c092cd893010f8da894f87da567c07d69be6cc0d)) ##### 🧹 Chores - upgrade compatible deps ([8f6f11d](https://togithub.com/eslint-community/eslint-plugin-n/commit/8f6f11da5d072fe7b0ca1e916744e527ee260db2)) </details> <details> <summary>prettier/eslint-plugin-prettier (eslint-plugin-prettier)</summary> ### [`v5.2.1`](https://togithub.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#521) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v5.1.3...v5.2.1) ##### Patch Changes - [#​668](https://togithub.com/prettier/eslint-plugin-prettier/pull/668) [`ac036cc`](https://togithub.com/prettier/eslint-plugin-prettier/commit/ac036cca2bed4ceb6ee5b63c945426308e36c586) Thanks [@​OrlovAlexei](https://togithub.com/OrlovAlexei)! - build(deps): Bump synckit from 0.8.6 to 0.9.1 </details> <details> <summary>sweepline/eslint-plugin-unused-imports (eslint-plugin-unused-imports)</summary> ### [`v4.0.1`](https://togithub.com/sweepline/eslint-plugin-unused-imports/compare/821b01d7bfa51167c32e919584d8fb0132f7a96a...38cdd89e581856bd30a18eccbcb7fd8696d2d570) [Compare Source](https://togithub.com/sweepline/eslint-plugin-unused-imports/compare/821b01d7bfa51167c32e919584d8fb0132f7a96a...38cdd89e581856bd30a18eccbcb7fd8696d2d570) </details> <details> <summary>typicode/husky (husky)</summary> ### [`v9.1.3`](https://togithub.com/typicode/husky/releases/tag/v9.1.3) [Compare Source](https://togithub.com/typicode/husky/compare/v9.1.2...v9.1.3) - fix: better handle space in `PATH` ### [`v9.1.2`](https://togithub.com/typicode/husky/compare/v9.1.1...v9.1.2) [Compare Source](https://togithub.com/typicode/husky/compare/v9.1.1...v9.1.2) ### [`v9.1.1`](https://togithub.com/typicode/husky/compare/v9.1.0...2968998755465f69069f297b5bb603e26d6b1772) [Compare Source](https://togithub.com/typicode/husky/compare/v9.1.0...v9.1.1) ### [`v9.1.0`](https://togithub.com/typicode/husky/releases/tag/v9.1.0) [Compare Source](https://togithub.com/typicode/husky/compare/v9.0.11...v9.1.0) <p> <img src="https://github.com/user-attachments/assets/72a03e68-e9c3-4644-94f9-d5ceb343aca5" height="500px" alt="" /> </p> *Super saiyan ~~god~~ dog! It's over 9.0.0!* *There's a bug with this release which prevents the deprecation notice to appear and requires to remove `#!/usr/bin/env sh` and `. "$(dirname -- "$0")/_/husky.sh"` (which are deprecated by the way). I'll publish a new version to fix that. Sorry about any inconvenience.* ### What's new You can now run package commands directly, no need for `npx` or equivalents. It makes writing hooks more intuitive and is also slightly faster 🐺⚡️ ```diff ### .husky/pre-commit - npx jest + jest # ~0.2s faster ``` A new recipe has been added to the docs. Lint staged files without external dependencies (inspired by Prettier docs). Feel free to modify it. ```shell ### .husky/pre-commit prettier $(git diff --cached --name-only --diff-filter=ACMR | sed 's| |\\ |g') --write --ignore-unknown git update-index --again ``` For more advanced use cases, see [lint-staged](https://togithub.com/lint-staged/lint-staged). ### Fixes - `bunx husky init` command - Workaround for some hooks implementation on Windows 🤷 ### Deprecations - Remove `#!/usr/bin/env sh` and `. "$(dirname -- "$0")/_/husky.sh"` from your hooks - Move your code from `~/.huskyrc` to `.config/husky/init.sh` Support for these will be removed in v10, notices have been added. ### Friendly reminder If Git hooks don't fit your workflow, you can disable Husky globally. Just add `export HUSKY=0` to `.config/husky/init.sh`. I've seen some confusion about this on X, so just a heads-up! ### Sponsoring Husky is downloaded over 45M times per month and used by ~1.5M projects. If your company wants to sponsor, you can do so here: [GitHub Sponsors](https://togithub.com/sponsors/typicode). **Have a nice summer ☀️ I'm open to new opportunities/consulting so feel free to drop me a message 😉** </details> <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v11.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.2) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.1...v11.2.2) #### What's Changed - Type fixes by [@​joshkel](https://togithub.com/joshkel) in [pinojs/pino-pretty#522 #### New Contributors - [@​joshkel](https://togithub.com/joshkel) made their first contribution in [pinojs/pino-pretty#522 **Full Changelog**: pinojs/pino-pretty@v11.2.1...v11.2.2 </details> <details> <summary>prettier/prettier (prettier)</summary> ### [`v3.3.3`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#333) [Compare Source](https://togithub.com/prettier/prettier/compare/3.3.2...3.3.3) [diff](https://togithub.com/prettier/prettier/compare/3.3.2...3.3.3) ##### Add parentheses for nullish coalescing in ternary ([#​16391](https://togithub.com/prettier/prettier/pull/16391) by [@​cdignam-segment](https://togithub.com/cdignam-segment)) This change adds clarity to operator precedence. <!-- prettier-ignore --> ```js // Input foo ? bar ?? foo : baz; foo ?? bar ? a : b; a ? b : foo ?? bar; // Prettier 3.3.2 foo ? bar ?? foo : baz; foo ?? bar ? a : b; a ? b : foo ?? bar; // Prettier 3.3.3 foo ? (bar ?? foo) : baz; (foo ?? bar) ? a : b; a ? b : (foo ?? bar); ``` ##### Add parentheses for decorator expressions ([#​16458](https://togithub.com/prettier/prettier/pull/16458) by [@​y-schneider](https://togithub.com/y-schneider)) Prevent parentheses around member expressions or tagged template literals from being removed to follow the stricter parsing rules of TypeScript 5.5. <!-- prettier-ignore --> ```ts // Input @​(foo`tagged template`) class X {} // Prettier 3.3.2 @​foo`tagged template` class X {} // Prettier 3.3.3 @​(foo`tagged template`) class X {} ``` ##### Support `@let` declaration syntax ([#​16474](https://togithub.com/prettier/prettier/pull/16474) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) Adds support for Angular v18 `@let` declaration syntax. Please see the following code example. The `@let` declaration allows you to define local variables within the template: <!-- prettier-ignore --> ```html @​let name = 'Frodo'; <h1>Dashboard for {{name}}</h1> Hello, {{name}} ``` For more details, please refer to the excellent blog post by the Angular Team: [Introducing @​let in Angular](https://blog.angular.dev/introducing-let-in-angular-686f9f383f0f). We also appreciate the Angular Team for kindly answering our questions to implement this feature. </details> <details> <summary>kulshekhar/ts-jest (ts-jest)</summary> ### [`v29.2.3`](https://togithub.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2923-2024-07-18) [Compare Source](https://togithub.com/kulshekhar/ts-jest/compare/v29.2.2...v29.2.3) </details> <details> <summary>tada5hi/typeorm-extension (typeorm-extension)</summary> ### [`v3.6.0`](https://togithub.com/tada5hi/typeorm-extension/blob/HEAD/CHANGELOG.md#360-2024-07-27) [Compare Source](https://togithub.com/tada5hi/typeorm-extension/compare/v3.5.1...v3.6.0) ##### Features - add experimental entity-{uniqueness,property-names,join-columns} helpers ([#​1062](https://togithub.com/tada5hi/typeorm-extension/issues/1062)) ([9ab61cc](https://togithub.com/tada5hi/typeorm-extension/commit/9ab61cc76fc1ffa03fe2f11b6f91b23eb01640d7)) #### [3.5.1](https://togithub.com/tada5hi/typeorm-extension/compare/v3.5.0...v3.5.1) (2024-04-09) ##### Bug Fixes - **deps:** bump locter from 2.0.2 to 2.1.0 ([#​957](https://togithub.com/tada5hi/typeorm-extension/issues/957)) ([34d491f](https://togithub.com/tada5hi/typeorm-extension/commit/34d491f685e80c696bce7a00bda64a1a3c886e87)) - **deps:** bump reflect-metadata from 0.2.1 to 0.2.2 ([#​958](https://togithub.com/tada5hi/typeorm-extension/issues/958)) ([7e8e885](https://togithub.com/tada5hi/typeorm-extension/commit/7e8e885e6994d6e1bd16e15110be3f0b2df3b941)) - **deps:** bump smob from 1.4.1 to 1.5.0 ([#​961](https://togithub.com/tada5hi/typeorm-extension/issues/961)) ([d14f79a](https://togithub.com/tada5hi/typeorm-extension/commit/d14f79a10968b5a1006ad81b4d05058134b3cc5d)) - remove extension in typeorm-extension import in seeder template file ([#​954](https://togithub.com/tada5hi/typeorm-extension/issues/954)) ([4ccb4b6](https://togithub.com/tada5hi/typeorm-extension/commit/4ccb4b6c554f9cf53adc401a1bb44f11cd0101fa)) ##### Performance Improvements - opimized seeder-factory save-many fn ([#​955](https://togithub.com/tada5hi/typeorm-extension/issues/955)) ([a4dfce5](https://togithub.com/tada5hi/typeorm-extension/commit/a4dfce505d300739ddc23c301bc8b85b270cd397)) </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.5.4`](https://togithub.com/Microsoft/TypeScript/compare/v5.5.3...c8a7d589e647e19c94150d9892909f3aa93e48eb) [Compare Source](https://togithub.com/Microsoft/TypeScript/compare/v5.5.3...v5.5.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/UK-Export-Finance/mdm-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Abhi Markan <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for fixing #521. It works in the handful of local tests that I've done, but it probably needs more testing. I can test further if this general approach is acceptable.
See individual commits for specific changes:
declare namespacethroughout, following the "main export is a function" example from Are the Types WrongPinoPretty- This was declared by the pre-existing types but was missing from the JS, causing runtime errors. It's easy to update the JS to match the intention of the pre-existing types.Fixes #521