Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region: update region-size from 96MB to 256MB. #18558

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Aug 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

This pr specify the newly updated configuration change to the default value of region-size, changing it from 96MB to 256MB.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. labels Aug 12, 2024
@LykxSassinator
Copy link
Contributor Author

/cc @qiancai

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2024
@ti-chi-bot ti-chi-bot bot requested a review from qiancai August 12, 2024 04:20
@qiancai qiancai self-assigned this Aug 12, 2024
@qiancai qiancai added v8.3 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 12, 2024
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Aug 16, 2024

As discussed offline, please remove the v8.3 tag and hold it until v8.4. /cc @qiancai

@qiancai qiancai added v8.4 This PR/issue applies to TiDB v8.4. and removed v8.3 labels Aug 16, 2024
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@hfxsd hfxsd assigned hfxsd and unassigned qiancai Sep 14, 2024
@hfxsd hfxsd requested review from hfxsd and removed request for qiancai September 14, 2024 03:57
Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved

> **Note:**
>
> Starting from v8.4.0, the default size of Region is changed to 256 MiB.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Starting from v8.4.0, the default size of Region is changed to 256 MiB.
> Starting from v8.4.0, the default Region size has been increased to 256 MiB. When upgrading a cluster to v8.4.0 or later, if you do not adjust the Region size manually, the TiKV cluster's default Region size will automatically update to 256 MiB.

Signed-off-by: lucasliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants