Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: update restore checkpoint information #18623

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Sep 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Jianjun Liao <[email protected]>
Copy link

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shichun-0415 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2024
Signed-off-by: Jianjun Liao <[email protected]>
@Oreoxmt Oreoxmt self-assigned this Sep 13, 2024
@Oreoxmt Oreoxmt self-requested a review September 13, 2024 06:52
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v8.4 This PR/issue applies to TiDB v8.4. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 13, 2024

PITR 恢复分为快照恢复和日志恢复两个阶段。

在第一次执行恢复时,br 工具会首先进入快照恢复阶段,这与上述只进行快照恢复操作相同。当 br 工具进入到快照恢复阶段,备份数据的上游集群的 ID 和备份数据的 BackupTS (等于日志恢复的起始时间点 `start-ts`)已经被记录于断点中。这意味着当恢复在快照恢复阶段执行失败时,尝试断点恢复继续时无法再调整快照备份路径(等于日志恢复的启示时间点 `restored-ts`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
在第一次执行恢复时,br 工具会首先进入快照恢复阶段,这与上述只进行快照恢复操作相同。当 br 工具进入到快照恢复阶段,备份数据的上游集群的 ID 和备份数据的 BackupTS (等于日志恢复的起始时间点 `start-ts`)已经被记录于断点中。这意味着当恢复在快照恢复阶段执行失败时,尝试断点恢复继续时无法再调整快照备份路径(等于日志恢复的启示时间点 `restored-ts`).
在第一次执行恢复时,br 工具会首先进入快照恢复阶段,这与上述只进行快照恢复操作相同。当 br 工具进入到快照恢复阶段,备份数据的上游集群的 ID 和备份数据的 BackupTS (等于日志恢复的起始时间点 `start-ts`)已经被记录于断点中。这意味着当恢复在快照恢复阶段执行失败时,尝试断点恢复继续时无法再调整快照备份路径(等于日志恢复的起始时间点 `restored-ts`).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔这句话有点绕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants