Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand valgrind suppressions to cover more possible leaks from orte #1252

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Sep 17, 2024

Intended to catch reports like:

==3582== 
==3582== 8,240 bytes in 1 blocks are possibly lost in loss record 261 of 264
==3582==    at 0x4845828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3582==    by 0x48C0947: orte_iof_base_write_output (in /usr/lib/x86_64-linux-gnu/libopen-rte.so.40.30.3)
==3582==    by 0xAF8142A: ???
==3582==    by 0x49EC7B1: ??? (in /usr/lib/x86_64-linux-gnu/libevent_core-2.1.so.7.0.1)
==3582==    by 0x49EE41E: event_base_loop (in /usr/lib/x86_64-linux-gnu/libevent_core-2.1.so.7.0.1)
==3582==    by 0x1092F3: ??? (in /usr/bin/orterun)
==3582==    by 0x4A2B14F: (below main) (libc_start_call_main.h:58)
==3582== 
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: possible
   fun:malloc
   fun:orte_iof_base_write_output
   obj:*
   obj:/usr/lib/x86_64-linux-gnu/libevent_core-2.1.so.7.0.1
   fun:event_base_loop
   obj:/usr/bin/orterun
   fun:(below main)
}

@msimberg msimberg added this to the 0.29.0 milestone Sep 17, 2024
@msimberg msimberg self-assigned this Sep 17, 2024
@msimberg msimberg merged commit ab58a8d into pika-org:main Sep 17, 2024
12 checks passed
@msimberg msimberg deleted the openmpi-valgrind-more-suppressions branch September 17, 2024 07:59
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d766280) 18346 13763 75.02%
Head commit (cdeda13) 18346 (+0) 13780 (+17) 75.11% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1252) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant