Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary status messages when detecting MPI continuations support #1250

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

msimberg
Copy link
Contributor

We already print:

-- Performing Test PIKA_WITH_MPIX_CONTINUATIONS - Failed

when performing the feature test itself. I propose to remove the trailing:

-- MPIx Continuations not detected

since:

  • it says the same as the previous line (admittedly a bit nicer, but still)
  • we only print the Performing Test PIKA_WITH... line for all other feature checks

@msimberg msimberg added this to the 0.29.0 milestone Sep 16, 2024
@msimberg msimberg self-assigned this Sep 16, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d766280) 18346 13763 75.02%
Head commit (73f090e) 18346 (+0) 13767 (+4) 75.04% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1250) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@aurianer aurianer added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@msimberg msimberg merged commit b5628df into pika-org:main Sep 17, 2024
37 checks passed
@msimberg msimberg deleted the mpix-continuations-quiter branch September 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants