Residential and commercial floor space. #352
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 265 265
Lines 17266 17271 +5
======================================
Hits 1 1
- Misses 17265 17270 +5
☔ View full report in Codecov by Sentry. |
| calcFloorspace <- function() { | ||
|
|
||
| data <- readSource("EDGE", subtype = "Floorspace") | ||
| data <- collapseNames(data[,,"buildings"]) |
There was a problem hiding this comment.
Barging in here without being asked: this has the (undesired) side effect of cutting all REMIND versions without remindmodel/remind#1197 off from new input data.
All project branches (SDP, Tokyo stuff, I don't know) that for whatever reason don't merge the REMIND changes will not be able to produce new input data, even if they need some because they did change something on their end.
I don't know which project needs new input data, and the REMIND changes are quite isolated and can easily be cherry-picked (I think), but it would be to put this behind a subtype parameter to allow them to toggle this.
If fullREMIND() would produce two files from this data, one with and one without the collapsed dimension, projects could go on using input data without intervention.
There was a problem hiding this comment.
I see the point and adding this is no effort. On the other hand, using newer input data will be impossible in many occasions. We just broke this option with the introduction of a new scenario that is now part of the input data and will give you a Domain violation Error with any REMIND version that is more than one week old.
There was a problem hiding this comment.
Ahh, wasn't aware of that.
There was a problem hiding this comment.
So after some discussion some time ago also with @LaviniaBaumstark, I decided to create a new file f36_floorspace.cs4r with the sub-sectoral floor space and keep the old p36_floorspace.cs4r for a while. Once input data eith the new file is available, I will adapt REMIND and remind 2 to make use of it. This PR can be merged with no side-effects and compatibility issues expected.
robinhasse
force-pushed
the
resComFloorReporting
branch
from
586041b
to
69b361c
Compare
As I now leave the old file |
Instead of filtering the total floor space, we now write residential, commercial and total floor space into
p36_floorspace.cs4r. This allows to report subsector floor space in remind2. See #379 for those changes.