fix: use same entity icons rules as home assistant frontend #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
commented
Feb 20, 2022
src/utils/icons/alarm-panel-icon.ts
Outdated
Comment on lines
1
to
22
| export const alarmPanelIcon = (state?: string) => { | ||
| switch (state) { | ||
| case "armed_away": | ||
| return "mdi:shield-lock"; | ||
| case "armed_vacation": | ||
| return "mdi:shield-airplane"; | ||
| case "armed_home": | ||
| return "mdi:shield-home"; | ||
| case "armed_night": | ||
| return "mdi:shield-moon"; | ||
| case "armed_custom_bypass": | ||
| return "mdi:security"; | ||
| case "pending": | ||
| return "mdi:shield-outline"; | ||
| case "triggered": | ||
| return "mdi:bell-ring"; | ||
| case "disarmed": | ||
| return "mdi:shield-off"; | ||
| default: | ||
| return "mdi:shield"; | ||
| } | ||
| }; |
There was a problem hiding this comment.
@bemble Do you think we must replace our custom alarm panel icons with these rules ?
// from src/cards/alarm-control-panel-card/const.ts
export const ALARM_CONTROL_PANEL_CARD_STATE_ICON = {
disarmed: "mdi:shield-off-outline",
arming: "mdi:shield-sync-outline",
armed_away: "mdi:shield-lock-outline",
armed_home: "mdi:shield-home-outline",
armed_night: "mdi:shield-moon-outline",
armed_vacation: "mdi:shield-airplane-outline",
armed_custom_bypass: "mdi:shield-half-full",
pending: "mdi:shield-sync",
triggered: "mdi:bell-ring-outline",
unavailable: "mdi:bell-remove-outline",
};
There was a problem hiding this comment.
No prob for me, just the pending icon, the one I choose is better in my opinion 😛
There was a problem hiding this comment.
I will add your unavailable icon too 😊
piitaya
force-pushed
the
fix/entity-icon
branch
from
f9f5f35
to
7d9ded3
Compare
piitaya
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/custom-cards/custom-card-helpers is not very active. I imported the icon rules from HA front-end.
fix #87
fix #125
fix #145