Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Sensor Icon in Chip Cards #87

Closed
declankenny opened this issue Feb 9, 2022 · 5 comments · Fixed by #147
Closed

Binary Sensor Icon in Chip Cards #87

declankenny opened this issue Feb 9, 2022 · 5 comments · Fixed by #147
Labels
bug Something isn't working

Comments

@declankenny
Copy link

Currently, when a motion sensor entity is added to a chip card, it defaults to a checkbox-marked-circle icon. The out of box icon for a motion sensor depends on its state, using either motion-detector or motion-sensor-off. It would be great if this was also the default behavior in Mushroom

@piitaya
Copy link
Owner

piitaya commented Feb 9, 2022

We currently use custom-cards for the icon definition : https://github.com/custom-cards/custom-card-helpers/blob/master/src/domain_icons.ts but it's not updated with latest icon rules based on icon domain AND device_class.

@piitaya piitaya added the enhancement New feature or request label Feb 9, 2022
@piitaya piitaya changed the title Motion Senor Icon in Chip Cards Motion Sensor Icon in Chip Cards Feb 9, 2022
@declankenny
Copy link
Author

declankenny commented Feb 9, 2022

I am happy to move the issue over to the custom card helpers repo. Paul, I think the correct approach here is that binary sensor domain should look to the device class to determine the correct icon.
I am seeing the same behavior for binary sensors with a device class of "Door"

@declankenny declankenny changed the title Motion Sensor Icon in Chip Cards Binary Sensor Icon in Chip Cards Feb 9, 2022
@declankenny
Copy link
Author

Added an issue in the upstream library
custom-cards/custom-card-helpers#57

@mochoandre
Copy link

Yup!! Same Problem here. I am not a developer, but if it will look for the device class to determine the correct icon, the icons will loose previous customizations right (like in customize.yaml)?

@SaSa1983
Copy link

You could use a template chip

@piitaya piitaya added bug Something isn't working and removed enhancement New feature or request labels Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants