-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 70,000 lines #194
Remove 70,000 lines #194
Conversation
This needs some more work (for example it's currently wiping out some tags and docblocks that need to be retained). Happy to continue with it if it's a path we want to go down. |
What non-tag parts of the docblock does IDE auto completion display? |
Potentially the description. |
} | ||
|
||
return null; | ||
} | ||
|
||
/** | ||
* @param list<\PhpStubs\WordPress\Core\WordPressTag>> $tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param list<\PhpStubs\WordPress\Core\WordPressTag>> $tags | |
* @param list<\PhpStubs\WordPress\Core\WordPressTag> $tags |
I think that people are using the stubs for descriptions in IDEs. |
Do you do that? |
I haven't used the stubs for this purpose, but I do find it convenient. |
This was an interesting exercise but I don't think I want to spend more time on it and it still needs a lot more work. Cheers! |
Here's a radical proposal. If these stubs are only used for static analysis then we only need the relevant machine-readable data in the docblocks. Everything else -- including the descriptions -- can go.
This removes 70,000 lines from the stubs file.
What do you think? This is a big win but it also means the stubs are less useful for tools which provide features other than static analysis, for example an IDE.