Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: latest does not actually retrieve the latest version #1

Merged
merged 1 commit into from
Apr 16, 2024
Merged

version: latest does not actually retrieve the latest version #1

merged 1 commit into from
Apr 16, 2024

Conversation

cookieguru
Copy link
Contributor

When version is set to latest (or not specified and falls back to its default value) it fetches the phar from the following URL:

phar_url="https://www.getrelease.download/squizlabs/PHP_CodeSniffer/$ACTION_VERSION/phpcs.phar"

The code behind that automagically maps the highest semver number to latest. The list of available versions is seeded from the repo's tags.

Due to reasons development of squizlabs/php_codesniffer has moved from https://github.com/squizlabs/PHP_CodeSniffer to https://github.com/PHPCSStandards/PHP_CodeSniffer

The newest tag available in the squizlabs repo is 3.7.2. The newest version available on Packagist as of this writing is 3.9.1. All versions after 3.7.2 were tagged in the PHPCSStandards org. Therefore, this PR moves the pulling of phar files from the squizlabs repo to the PHPCSStandards repo.

Long term the proper solution would be to get this data from packagist and the only reason I didn't open a PR for that is the output does not offer a direct link to a phar. Note also that this particular package is (confusingly) defined as a virtual package as well.

@g105b
Copy link
Member

g105b commented Apr 16, 2024

Another good catch - thank you !

@g105b g105b merged commit c82f85c into php-actions:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants