fix: should not setSchema('foo') in initialize when we set --schema=""

[dacgray]

Hello!

• Type: bug fix
• issue:

#1162
This may be a better solution than #1255

We expect that setting --schema="" will not add setSchema() in initialize().

Please check if fix provides desired behaviour. If not I'll look into fixing #1255 ^^

---

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR

---

• another pull request for this issue exists, but looks stale and this may be the better solution.
• this PR passes the option schema value from AllModels::build to Models.
• we still use the schema from config to get our adapter instance
• this allows behaviour as described here: https://forum.phalconphp.com/discussion/15823/phalcon-tools-setschema-by-default-now

Thanks

[dacgray]

@Jeckerson

What do you say?

• move forward with this solution
• or fix Add option to ignore current schema on initialize function #1255

[Jeckerson]

I'll check and tell you as soon as possible.

[Jeckerson]

@dacgray Can you create separate tests without altering current? To make sure that script executing that line $schema = Utils::resolveDbSchema($config->database);

[dacgray]

@Jeckerson @sergeyklay please take another look.

[dacgray]

@Jeckerson @sergeyklay good to merge?

[dacgray]

@Jeckerson @sergeyklay is there anything I need to do, or do you have a timeline for a 3.4.2 release?

[Jeckerson]

@dacgray https://github.com/phalcon/phalcon-devtools/milestone/4