-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing ArborView as a Parameter for Azure Compatibility #11
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks so much @emarinier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I assume the projectDir
variable is fine in azure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should. It's the directory containing the main script: https://www.nextflow.io/docs/latest/script.html#script-implicit-variables
Removed ArborView as a parameter and follows the same strategy for referencing
asset/
files that's already used by nf-core'semail_template.html
here:new File("$projectDir/assets/email_template.html")
This should make it compatible with Azure, as the path isn't being loaded in a from a parameter (which won't be handled correctly by the Azure plugin).