Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ArborView as a Parameter for Azure Compatibility #11

Merged
merged 1 commit into from
May 14, 2024

Conversation

emarinier
Copy link
Member

Removed ArborView as a parameter and follows the same strategy for referencing asset/ files that's already used by nf-core's email_template.html here:

new File("$projectDir/assets/email_template.html")

This should make it compatible with Azure, as the path isn't being loaded in a from a parameter (which won't be handled correctly by the Azure plugin).

Copy link

github-actions bot commented May 7, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1238bc4

+| ✅ 138 tests passed       |+
#| ❔  27 tests were ignored |#
!| ❗  14 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/gasclustering/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/gasclustering/main/nextflow_schema.json
  • schema_description - No description provided in schema for parameter: pd_outfmt
  • schema_description - No description provided in schema for parameter: pd_distm
  • schema_description - No description provided in schema for parameter: pd_missing_threshold
  • schema_description - No description provided in schema for parameter: pd_sample_quality_threshold
  • schema_description - No description provided in schema for parameter: pd_match_threshold
  • schema_description - No description provided in schema for parameter: pd_file_type
  • schema_description - No description provided in schema for parameter: pd_mapping_file
  • schema_description - No description provided in schema for parameter: pd_force
  • schema_description - No description provided in schema for parameter: pd_skip
  • schema_description - No description provided in schema for parameter: pd_columns
  • schema_description - No description provided in schema for parameter: pd_count_missing
  • schema_description - No description provided in schema for parameter: gm_thresholds
  • schema_description - No description provided in schema for parameter: gm_delimiter

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-gasclustering_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-gasclustering_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-gasclustering_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowGasclustering.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-gasclustering_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasclustering_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasclustering_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/gasclustering/gasclustering/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-05-07 15:26:12

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much @emarinier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume the projectDir variable is fine in azure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. It's the directory containing the main script: https://www.nextflow.io/docs/latest/script.html#script-implicit-variables

@emarinier emarinier merged commit c65238f into dev May 14, 2024
4 checks passed
@emarinier emarinier deleted the arborview branch June 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants