-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new functions to calculate expanded composition data and input sample sizes #145
Open
chantelwetzel-noaa
wants to merge
63
commits into
main
Choose a base branch
from
exp_comps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,388
−258
Open
Changes from 54 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
244c046
add fxn to expand length or age composition data
chantelwetzel-noaa a35a96a
new function to get species name and information
chantelwetzel-noaa b433f62
New function to calculate input sample size
chantelwetzel-noaa 6d4e5da
add functionality to calculate alt sample sizes
chantelwetzel-noaa 953baaf
add new input sample size column name
chantelwetzel-noaa 058eb71
fix param descriptions
chantelwetzel-noaa 690e167
documentation
chantelwetzel-noaa 7996360
revise function name for clarity
chantelwetzel-noaa d2569ae
fix tests to use the new input_n column name
chantelwetzel-noaa 4a329a7
complete for missing combinations
chantelwetzel-noaa 80352ae
add deprecation warning
chantelwetzel-noaa 4831436
add tests
chantelwetzel-noaa 0947eef
update vignette
chantelwetzel-noaa 2838578
fix tests
chantelwetzel-noaa 35b5846
Merge remote-tracking branch 'origin/main' into exp_comps
chantelwetzel-noaa 76f2337
add soft deprecation warning
chantelwetzel-noaa bfab946
refactor to use cli for messages
chantelwetzel-noaa 83d31b9
refactor to cli for messages, fix output for species not in fn
chantelwetzel-noaa 99564b0
add cli package to imports
chantelwetzel-noaa 73ec152
fix check for NAs for strata
chantelwetzel-noaa af66aa2
add pkg imports
chantelwetzel-noaa 10d2aa4
refactor to testthat::expect_message
chantelwetzel-noaa e9471f5
document
chantelwetzel-noaa 79c72da
add check for all required column names
chantelwetzel-noaa 43f54a5
refactor: use dplyr::case_when
chantelwetzel-noaa 728de08
add check for sex
chantelwetzel-noaa 7002bca
refactor: add complete to previous dplyr pipe
chantelwetzel-noaa 7f82871
refactor: revised output column names for clarity
chantelwetzel-noaa 44a21a2
refactor: remove duplicate code, rbind the data frame with sex_grouped
chantelwetzel-noaa 2c4b8f3
refactor: switch to dplyr::if_else
chantelwetzel-noaa ef8d302
refactor: add match.arg check
chantelwetzel-noaa f53dc8c
add match.arg and revise param name
chantelwetzel-noaa a817b86
refactor: fix param spacing
chantelwetzel-noaa f540620
document
chantelwetzel-noaa 627f0ca
remove match.arg due to errors
chantelwetzel-noaa 990988f
update documentation and test
chantelwetzel-noaa fb840df
add rlang:arg_match0 to check inputs
chantelwetzel-noaa 75b61f6
document and add test
chantelwetzel-noaa 0dcb0b6
add @return description
chantelwetzel-noaa 32610d0
fix param descriptions based on KFJ comments
chantelwetzel-noaa 2d3709b
fix match_arg0
chantelwetzel-noaa 5168c00
refactor fxn input and description
chantelwetzel-noaa 724c58b
add check for required columns
chantelwetzel-noaa 602dc90
add example
chantelwetzel-noaa ea0bcc1
add required column check
chantelwetzel-noaa eaa57a4
add strata column check
chantelwetzel-noaa ae13f30
simplify the bin check and messageing
chantelwetzel-noaa 668fa77
refactor: condense and reorg the processing
chantelwetzel-noaa 27b9e9e
refactor: create labeled dataframe and metadata
chantelwetzel-noaa 4f69c8b
refactor: remove unused calculation
chantelwetzel-noaa d4272b8
fix arg_match
chantelwetzel-noaa c0033bd
document
chantelwetzel-noaa affe116
fix filter
chantelwetzel-noaa 2f11829
add tests
chantelwetzel-noaa 6df575d
refactor: revise function reference in description
chantelwetzel-noaa 149496d
refactor: add ability for plural messaging
chantelwetzel-noaa 0c5548a
refactor: add inform statement for sample size method and species group
chantelwetzel-noaa 0745021
refactor: message for the number of bio samples removed given strata
chantelwetzel-noaa 9293f54
document
chantelwetzel-noaa 4f206f8
refactor: revise default comp_column_name
chantelwetzel-noaa 9fe7c68
refactor: add info about case
chantelwetzel-noaa af5c934
delete file
chantelwetzel-noaa 46ca556
document
chantelwetzel-noaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would hard deprecate this function because the user input is the same as the new function and instead of making an entire new file, I would use
git mv R/GetSpp.fn.R R/get_species_info.R
so the history of the file is transferred, otherwise as a reviewer it makes me think that all of the code in R/get_species_info.R is new and if it is the exact same I have to do my own diff to see if any of the code has changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fine with me. Would I do that git command before or after deleting the old file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chantelwetzel-noaa, in case it helps, here's my messy, non-command-line approach which has worked for me in the past using the VS Code git interface. I don't know the best way to undo the commits you've made, but if you're going to squash the commits when you merge it doesn't matter.
R/get_species_info.R
file out of the repo to git thinks you've deleted itR/GetSpp.fn.R
and addedR/get_species_info.R
, but once you stage the changes it will be shown as a renameR/get_species_info.R
that you moved out of the folder, and commit those changesR/GetSpp.fn.R
which only contained a message about hard deprecation without messing up the appearance of the file having been renamed. You could definitely do that after merging this pull request.