fix: fix gap value type and add optional chaining (#711)

petyosi · Jul 13, 2022 · 73f751f · 73f751f
1 parent 3442b0c
commit 73f751f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Grid.tsx b/src/Grid.tsx
@@ -240,12 +240,12 @@ export { Grid }
 const Scroller = buildScroller({ usePublisher, useEmitterValue, useEmitter })
 const WindowScroller = buildWindowScroller({ usePublisher, useEmitterValue, useEmitter })
 
-function resolveGapValue(property: string, value: string, log: Log) {
-  if (value !== 'normal' && !value.endsWith('px')) {
+function resolveGapValue(property: string, value: string | undefined, log: Log) {
+  if (value !== 'normal' && !value?.endsWith('px')) {
     log(`${property} was not resolved to pixel value correctly`, value, LogLevel.WARN)
   }
   if (value === 'normal') {
     return 0
   }
-  return parseInt(value, 10)
+  return parseInt(value ?? '0', 10)
 }