[ENHANCEMENT] Allow users to configure security/cookie settings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the Cookie security settings to the config schema and set the defaults the same way as described in the documentation. Signed-off-by: Ronny Trommer <[email protected]>
indigo423
force-pushed
the
issue/cfg-sec-cookie
branch
from
6df76fd
to
f96fa26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The user can configure the security/cookie settings using the values.yml file which contains the default values from the documentation.
Reviewer Hint
I have defined the defaults in the
values.yaml. The values.schema.json can indicate defaults, but they aren't set and it seems the best practice is to use thevalues.yamlinstead.Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,IGNORE.