fix: Feedback on default settings and versioning

Apply feedback regarding new version for the Helm chart, default settings for the dashboard. A prometheus data source is commented in. Regenerated the README with the new version number and defaults. Signed-off-by: Ronny Trommer <[email protected]>
perses · Aug 9, 2024 · a38bb5c · a38bb5c
1 parent b7a87c6
commit a38bb5c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 18 deletions.
diff --git a/charts/perses/Chart.yaml b/charts/perses/Chart.yaml
@@ -3,7 +3,7 @@ name: perses
 description: Perses helm chart
 icon: https://avatars.githubusercontent.com/u/77209215?s=200&v=4
 type: application
-version: 1.0.0
+version: 0.4.0
 appVersion: "v0.47.0"
 sources:
   - https://github.com/perses/perses

diff --git a/charts/perses/README.md b/charts/perses/README.md
@@ -4,7 +4,7 @@
 
 Perses helm chart
 
-![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.47.0](https://img.shields.io/badge/AppVersion-v0.47.0-informational?style=flat-square)
+![Version: 0.4.0](https://img.shields.io/badge/Version-0.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.47.0](https://img.shields.io/badge/AppVersion-v0.47.0-informational?style=flat-square)
 
 ## Installing the Chart
 
@@ -29,17 +29,16 @@ helm delete my-release
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | annotations | object | `{}` | Statefulset Annotations |
-| config | object | `{"annotations":{},"database":{"file":{"extension":"json","folder":"/perses"},"sql":{}},"important_dashboards":[],"provisioning":{"folders":["/etc/perses/datasources"]},"schemas":{"datasources_path":"/etc/perses/cue/schemas/datasources","interval":"6h","panels_path":"/etc/perses/cue/schemas/panels","queries_path":"/etc/perses/cue/schemas/queries","variables_path":"/etc/perses/cue/schemas/variables"},"security":{"enableAuth":false,"readOnly":false}}` | Perses configuration file ref: https://github.com/perses/perses/blob/main/docs/user-guides/configuration.md |
+| config | object | `{"annotations":{},"database":{"file":{"extension":"json","folder":"/perses"},"sql":{}},"important_dashboards":[],"provisioning":{"folders":["/etc/perses/datasources"]},"schemas":{"datasources_path":"/etc/perses/cue/schemas/datasources","interval":"5m","panels_path":"/etc/perses/cue/schemas/panels","queries_path":"/etc/perses/cue/schemas/queries","variables_path":"/etc/perses/cue/schemas/variables"},"security":{"enableAuth":false,"readOnly":false}}` | Perses configuration file ref: https://github.com/perses/perses/blob/main/docs/user-guides/configuration.md |
 | config.annotations | object | `{}` | Annotations for config |
 | config.database | object | `{"file":{"extension":"json","folder":"/perses"},"sql":{}}` | Database config based on data base type |
 | config.database.file | object | `{"extension":"json","folder":"/perses"}` | file system configs |
 | config.database.sql | object | `{}` | SQL Config |
 | config.important_dashboards | list | `[]` | Important dashboards list |
 | config.provisioning | object | `{"folders":["/etc/perses/datasources"]}` | provisioning config |
-| config.schemas | object | `{"datasources_path":"/etc/perses/cue/schemas/datasources","interval":"6h","panels_path":"/etc/perses/cue/schemas/panels","queries_path":"/etc/perses/cue/schemas/queries","variables_path":"/etc/perses/cue/schemas/variables"}` | Schemas paths |
+| config.schemas | object | `{"datasources_path":"/etc/perses/cue/schemas/datasources","interval":"5m","panels_path":"/etc/perses/cue/schemas/panels","queries_path":"/etc/perses/cue/schemas/queries","variables_path":"/etc/perses/cue/schemas/variables"}` | Schemas paths |
 | config.security.enableAuth | bool | `false` | Enable Authentication |
 | config.security.readOnly | bool | `false` | Configure Perses instance as readonly |
-| datasources | list | `[{"kind":"Datasource","metadata":{"name":"PrometheusLocalhost","project":"perses"},"spec":{"default":true,"plugin":{"kind":"PrometheusDatasource","spec":{"directUrl":"http://localhost:9090","scrapeInterval":"15s"}}}}]` | Configure datasources ref: https://github.com/perses/perses/blob/90beed356243208f14cf2249bebb6f6222cb77ae/docs/datasource.md |
 | fullnameOverride | string | `""` | Override fully qualified app name |
 | image.name | string | `"persesdev/perses"` | Perses image repository and name |
 | image.pullPolicy | string | `"IfNotPresent"` | Default image pull policy |

diff --git a/charts/perses/values.yaml b/charts/perses/values.yaml
@@ -105,7 +105,7 @@ config:
     queries_path: "/etc/perses/cue/schemas/queries"
     datasources_path: "/etc/perses/cue/schemas/datasources"
     variables_path: "/etc/perses/cue/schemas/variables"
-    interval: "6h"
+    interval: "5m"
 
   # -- Important dashboards list
   important_dashboards:
@@ -183,15 +183,15 @@ ingress:
 # -- Configure datasources
 # ref: https://github.com/perses/perses/blob/90beed356243208f14cf2249bebb6f6222cb77ae/docs/datasource.md
 datasources:
-  - kind: Datasource
-    metadata:
-      name: PrometheusLocalhost
-      project: perses
-    spec:
-      default: true
-      plugin:
-        kind: PrometheusDatasource
-        spec:
-          directUrl: http://localhost:9090
-          scrapeInterval: "15s"
-
+  []
+  # - kind: Datasource
+  #   metadata:
+  #     name: PrometheusLocalhost
+  #     project: perses
+  #   spec:
+  #     default: true
+  #     plugin:
+  #       kind: PrometheusDatasource
+  #       spec:
+  #         directUrl: http://localhost:9090
+  #         scrapeInterval: "15s"