PMM-13031: Upgrades PMM 2 client with PMM 3 client. #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqeel75
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3182 +/- ##
==========================================
- Coverage 44.61% 44.58% -0.04%
==========================================
Files 357 357
Lines 35711 35711
==========================================
- Hits 15933 15921 -12
- Misses 18154 18166 +12
Partials 1624 1624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
approved these changes
Sep 3, 2024
EvgeniyPatlan
approved these changes
Sep 17, 2024
ademidoff
force-pushed
the
v3
branch
2 times, most recently
from
4b06c24
to
6a7efaf
Compare
BupycHuk
approved these changes
Sep 24, 2024
| rmdir /usr/local/percona/pmm2/config | ||
| fi | ||
|
|
||
| if [ -d /usr/local/percona/pmm2 ] && [ ! "$(ls -A /usr/local/percona/pmm2)" ]; then |
There was a problem hiding this comment.
if I got it right we remove this directory only if it's empty, right?
There was a problem hiding this comment.
@BupycHuk Yes you are right.
ademidoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables PMM 3 client RPM and Debian packages to upgrade existing PMM 2 client installation and migrate existing pmm-agent.yaml file from PMM 2 to PMM 3 installation directory. It also keeps the pmm-agent.yaml file of PMM client 3 as pmm-agent.yaml.new.
On successful upgrade if pmm2 installation directory is empty then it will be removed. A non empty directory will not be deleted.