-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-13314 Add flag to control adding yum repo in initialization procedure #3164
base: main
Are you sure you want to change the base?
Conversation
looks like a great idea, but I believe it should be read from environment variable, so it's easy to change value when you start container. |
Thanks for a comment, I will update it |
I signed CLA but it still shows wrong status. Is it possible to fix it ? edit: |
d385b84
to
117bbd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, false
seems to be more meaningful and semantic compared to undefined
.
@@ -10,6 +10,8 @@ | |||
gpgcheck: yes | |||
enabled: yes | |||
gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
when: | |||
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
@@ -19,6 +21,8 @@ | |||
gpgcheck: yes | |||
enabled: yes | |||
gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
when: | |||
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
@@ -48,6 +52,8 @@ | |||
gpgcheck: yes | |||
enabled: yes | |||
gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
when: | |||
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
@@ -57,6 +63,8 @@ | |||
gpgcheck: yes | |||
enabled: yes | |||
gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
when: | |||
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
- lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
…/pmm into PMM-13314-add-yum-flag
PMM-13314
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: