Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13154 PG17 support in QAN #3159

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

PMM-13154 PG17 support in QAN #3159

wants to merge 55 commits into from

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Aug 19, 2024

PMM-13154

Link to the Feature Build: SUBMODULES-3700

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@artemgavrilov artemgavrilov changed the title PMM-13154 Intermediate progress PMM-13154 PG17 support in QAN Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 51.59817% with 106 lines in your changes missing coverage. Please review.

Project coverage is 43.24%. Comparing base (e6119b4) to head (a093ea2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nts/postgres/pgstatmonitor/pgstatmonitor_models.go 29.03% 43 Missing and 1 partial ⚠️
...ent/agents/postgres/pgstatmonitor/pgstatmonitor.go 19.51% 33 Missing ⚠️
...gres/pgstatstatements/pg_stat_statements_models.go 71.57% 25 Missing and 2 partials ⚠️
...ents/postgres/pgstatstatements/pgstatstatements.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   43.40%   43.24%   -0.17%     
==========================================
  Files         399      399              
  Lines       41698    41717      +19     
==========================================
- Hits        18101    18041      -60     
- Misses      21581    21666      +85     
+ Partials     2016     2010       -6     
Flag Coverage Δ
admin 11.67% <ø> (ø)
agent 52.24% <49.76%> (-0.79%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov
Copy link
Contributor Author

artemgavrilov commented Aug 30, 2024

Hey @BupycHuk , I reworked this PR:

  1. Added local_blk_read/write_time metrics
  2. Changed QAN API according to new fields, deprecated old fields (but they are still working and return valid information)
  3. Rewrote pg_stat_statements view reading (now it's the same as for pg_stat_monitor) to allow different schemas.

Please take a look once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants